Repository navigation
Conversation
13 drops were already on master or superseded and are deleted. 19 are promoted and deleted in this commit: seven BUG-DRAFT entries and a BUG-39 addendum in bug-logs/mxcli-bugs.md, an addendum A1-A19 to the not-filed 0.26 round-trip report, and short notes in on-demand skills (fixture-seeding, learned-constants-and-secrets, rest-integration, e2e-harness-base, learned-workflow-patterns, learned-page-patterns, learned-file-upload-widget, existing-app-change, app-analysis, doctor-triage, mdl-cookbook-microflows) plus the mxpatch.py docstring. The seven 2026-09-27 pending upstream drafts no longer cite a deleted inbox file. No baseline skill text changed (render-routing --check: 65568 / 80000 before and after). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. One DELETE verdict loses content: the 9.24 runtime-boot facts in Value: Clears 32 of the 43 drops. Each promotion is deleted in the same commit, and promoted text goes to on-demand files. DELETE spot-check, 6 rows: 5 are OK, with the content on master at the cited lines.
PROMOTE spot-check: all 7 rows are faithful, with matching numbers. One gap: the retry-loop row leaves out the drop's limit that the repeat path is not exercised. No client names; the added names are generic. Regression risk: Nothing executable changed ( Correctness: The seven Context cost: 65,568 → 65,568 (measured). Time cost: none. Exact fixes required:
Generated by Claude Code |
…the retry loop's limit Independent review (MERGE-AFTER-FIX): the increment-4 seam-probe drop was marked DELETE, but its 9.24 runtime-boot facts were nowhere outside the inbox. Moved to PROMOTE: five lines in decompose-app.md Stage 0 item 3 (Java 11 plus MX_INSTALL_PATH, every constant in update_configuration, mxbuild 9.24 with --java-home=<jdk17>, the Java API edits on the 10.24 copy), worded and versioned as in the drop. The retry-loop cookbook row now carries the drop's limit: the loop's repeat path was not exercised. Counts are now 12 deleted and 20 promoted (32 still leave the queue). decompose-app and mdl-cookbook-microflows are on demand: baseline 65568 / 80000 unchanged; mdl-rules --check in sync. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review fixes pushed in c08bcd6.
Corrected counts: 12 deleted, 20 promoted, 11 kept. This supersedes the body's "13 / 19";
Generated by Claude Code |
|
Review: MERGE — re-review of c08bcd6: the 9.24 runtime-boot facts are promoted into
The drop's REST point ("10.24→11.13 needed no mappings") is already covered at Generated by Claude Code |
Direct lane
What changed and why (one paragraph):
contrib/inbox/had 43 drops (Aug–Nov 2026), and CONTRIBUTING.md calls the inbox "a queue, never an archive". This PR is triage sweep 1. Every drop got one row: its claims, whether each claim is already on master (cited file:line), stale, or new, and a verdict.## BUG-DRAFT-*entries plus a BUG-39 addendum inbug-logs/mxcli-bugs.md;project-bin/mxpatch.pydocstring.Related cleanup:
Source:line now describes the source instead.Not in this PR:
project-tests/e2e/helpers.js:633-635fullPageShotusesfullPage: true, which crops an Atlas page at the viewport. It deserves its own fix PR with a field capture.Impact
bug-logs/mxcli-bugs.md(append-only, plus the 3-line BUG-39 addendum), the round-trip report (append-only), andproject-bin/mxpatch.py(docstring only,ast.parseclean). No_common.sh,exec.sh,skill-routing.tsvormdl-rule-kinds.tsvchange.render-routing.sh --check).mdl-rules.sh --checkis in sync. On-demand skills and the docstring grow by 936 words, andbug-logs/by 1,586.Time cost: none · 0 s · can force rework: n · offset: n/a
Field evidence: none new. Every promoted line carries the field run, date and versions its drop recorded (mxcli v0.21–v0.27, Mendix 10.24–11.15). Defects from before v0.25 are marked "not retested".
LEAKGUARD_ALLOW_NO_DENYLIST=1, so the name check was not exercised. CI's denylist will confirm.check-pr-discipline,render-routing --check,mdl-rules --check,check-scripts(145/145 + 30/30),check-portabilityandcheck-no-private-citationsare all clean. No fixture run: the only code file changed in its docstring.CHANGELOG.mdline appended, crediting "inbox sweep, contributors named in each promoted entry"## BUG-DRAFT-<slug>:Review: pending independent review
Generated by Claude Code