Repository navigation
Conversation
Two causes, both reproduced with the reported text: 1. `init-project.sh .` took basename "." as the project name and wrote `\b.\b` to the toolkit clone's denylist, which file-bugs.py reads: every space and hyphen became <redacted> and the scan refused the report. init-project.sh now resolves the folder first, writes the name regex-escaped, dedupes on that exact line, and refuses a name under 3 characters. file-bugs.py ignores, with a warning, any deny pattern that matches empty text, a space or "a-b c", which repairs existing clones. 2. Attribute names matched inside ordinary words: Round turned "Workaround" into "WorkaAttrN", and Used redacted "used". Attributes now match only where an identifier segment starts; a short or common-word one only in its model spelling. ACT_Round_Save, $w/Used, Kundennummer2 and kundennummerold are still redacted. tests/wave2/test-file-bugs.sh section S: master 219 pass / 5 fail, branch 224 pass / 0 fail. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. The new "drop match-everything deny lines" logic fails open. A deny line with a trailing Value: Fixes #759 as titled; the body is #760's, as triage noted. Both causes are real and both are fixed:
Existing clones that hold Regression risk:
Correctness: test-file-bugs 224/0 on one run. Another run hit a flaky, unrelated Context cost: 65568 → 65568 (measured). Time cost: none per build row. Exact fixes required:
Generated by Claude Code |
…s a name Independent review of #815 (MERGE-AFTER-FIX): - add() drops a probe-matching deny line only when it holds no name (no run of 3+ letters/digits: `\b.\b`, `\b\b`). Any other probe-matching line (`Acmecorp|Initrode|`, `(Acmecorp)?`) goes to bad_deny, so posting, --links and --json are refused until it is fixed, as for an invalid line. Before, it was dropped with a warning and the names posted in clear. - attr_pat docstring and CHANGELOG state the accepted limit: a distinctive attribute in a lowercase compound (prekundennummer) and an all-caps weak one (USED) are no longer redacted. Fixture S: two new refusal checks (fail on the pre-fix head, 225/2) and a check that the nameless line is still dropped with a warning; 227/0 on the branch. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review fixes pushed in d8137fa:
Fixture results:
Needs a re-review. Generated by Claude Code |
|
Review: MERGE-AFTER-FIX — the fail-closed branch works for ASCII names, but the "holds a name" test is
A legitimate list (
Generated by Claude Code |
…refused (#815 review) [A-Za-z0-9]{3,} missed names with non-ASCII letters: Öko| was dropped with a warning and the name posted in clear. Use [^\W_]{3,}; fixture S checks Öko|. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE — re-review of 3379387: the name test is now Unicode-aware (
No name leaks through a match-everything line any more. A legitimate list ( Generated by Claude Code |
Fixes #759
Note: the bodies of #759 and #760 look swapped (see the triage comment). This PR fixes #759's title, file-bugs.sh redaction garbling ordinary English. The reproduction uses the file-bugs text from #760's body.
Direct lane
What changed and why (one paragraph): Two separate causes, each reproduced on origin/master with the reported text. The garbled title came out byte for byte as reported:
journey<redacted>runner: 'row' never<redacted>matches<redacted>….(1) A project named
.bin/init-project.sh .tookbasename .as the project name and wrote\b.\binto the toolkit clone's.leakguard-deny.file-bugs.pyreads that file, so every space, hyphen and one-letter word was redacted.init-project.sh: resolve the folder (cd && pwd) beforebasename; write the name regex-escaped; dedupe on that exact line; refuse a name under 3 characters, with a NOTE.file-bugs.py: drop, with a warning, any deny pattern that matches""," "ora-b c. This repairs clones that already hold the bad line.(2) Attribute names inside ordinary words
WorkaAttrN(attributeRound), and the weak attributeUsedmatched the prose word "used".attr_pat(), for attributes only.ACT_Round_Save,$w/UsedandmyRoundare still redacted.Deviation from the triage's (c): applying
sub=Falseto every attribute breaks two existing section M checks (Kundennummer2,kundennummerold), soattr_patkeeps them. Known limit: the whole word "round" in prose is still redacted for an attribute namedRound; only "Workaround" is fixed.Impact
init-project.shno longer registers a name under 3 characters (it prints a NOTE).file-bugs.shwarns when it ignores a match-everything deny line. A report refused only because of such a line is no longer refused.bin/init-project.sh(leak-guard registration block andPROJECT_NAME),bin/lib/file-bugs.py, the fixture, CHANGELOG.PROJECT_NAMEalso feeds the PROJECT.md title: forinit-project.sh .it is now the folder name instead of.. POSIX tools only.Time cost: per filing · three regex probes per deny pattern · can force rework: n · offset: removes the unreadable, always-refused reports in every clone that ran
init-project.sh .Field evidence: reported by thanarat (toolkit v2026.10.19-134, macOS). Reproduced here on master with the exact reported title and body. Master's
init-project.sh .was confirmed to write\b.\b.Fixture:
tests/wave2/test-file-bugs.sh, new section S with 6 checks.test-file-bugs.shtest-guide-reopen.shtest-init-autocompact.shOne branch run made in parallel with the master run showed one unrelated, load-dependent FAIL in section P. It passed on the sequential re-run (224/0).
check-scripts,check-portabilityandcheck-pr-disciplineare cleansedandgrep -qixF.CHANGELOG.mdline appended, crediting thanarat (file-bugs.sh: redaction replaces spaces and hyphens in ordinary English text, which makes the issue unreadable #759)Review: pending independent review
Generated by Claude Code