Repository navigation
Conversation
…r for ui.no5xx (#818) Mendix answers a refused save with HTTP 551 and a {"datavalidation":[...]} body. The opt-in no5xx row counted every answer >= 500, so a negative-path step whose save was refused by design read FAIL. The listener now reads a 551's body (helpers.isValidationFeedback, same shape as #814's monkey classifier) and records a datavalidation answer as a note on the row; record5xx awaits those body reads. A 500, and a 551 with any other or unreadable body, stay hits. Golden input is the verbatim 551 captured from a live Mendix 11.8.0 runtime. The existing back/no5xx fixture's wiring grep accepts `await record5xx();`. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
…ntainer (#812) page.screenshot({ fullPage: true }) measures the document. Atlas_SideBar and Atlas_TopBar on Mendix 11.8 scroll .mx-scrollcontainer-center inside a viewport-tall document, so the shot was cut at the viewport. fullPageShot now finds the largest scroller spanning at least half the viewport, grows the viewport by its hidden height (up to three times, capped at 16000 px, stopping when growth no longer shrinks it), shoots, and restores the viewport. It returns a record with scrollRoot, documentPx, contentPx, capturedPx and complete. Atlas_Default keeps plain fullPage. The wait after a resize is page.waitForTimeout, not requestAnimationFrame: a saved MHTML page never runs rAF, which hung the first version against the captured fixture. A failed shot is no longer swallowed: the record carries `error`, and a transient "Unable to capture screenshot" (1 in 10 fixture runs on a loaded 4-CPU box) is retried once. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
DOM_PROBE selected lists with [class*="widget-datagrid"], which matched a DataGrid2's root and eight of its parts. Four parts hold no row, so live/empty-list-message (P1) reported "9 lists on screen; 4 empty" on a 20-row grid. The selector now uses the .widget-datagrid class token. The fixture lifts DOM_PROBE from page-audit.js and runs it over a captured 11.8 page. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX —
Generated by Claude Code |
…root (review of #825) The independent review found that the first version picked the scroller with the largest hidden height among those at least half the viewport tall. A fixed-height DataGrid2 body (480 px) then became the "root". The shot grew to 4196 px, mostly blank, on Atlas_Default, where master shot the 900 px document. The record still said complete. - The root is now the OUTERMOST qualifying scroller, tagged so the same element is re-measured. - After each grow, the root's own clientHeight must have grown by at least half the added height. If it did not, the scroller is not tied to the viewport: restore, then take the plain fullPage. The record names it in skippedScroller. - complete is the root's own leftover scroll (<= 4 px), not a re-pick against a moved threshold. Fixture: the captured Default and SideBar MHTML, re-run with one appended CSS rule. The rule makes .widget-datagrid-grid-body a fixed 480 or 800 px scroller. Results: - previous branch helpers: 6/4; - this commit: 10/0. Live 11.8 run, injected 480 px grid body: Default 900 (was 4196), SideBar 900 (was 2148). Plain SideBar and TopBar are still 1244 and 1239; Default is still 1278. CAPTURE.txt and the fixture header now give the capture's real row count: 30 rows, 20 per page. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE — re-review at 7070fa4. The fixed-height-scroller regression is fixed: on a live 11.8 app, a fixed-height grid body no longer grows the viewport, and the outermost scroller is now the shot root. Generated by Claude Code |
Fixes #818
Fixes #812
Direct lane
What changed and why (one paragraph):
Three runtime-instrument defects, each reproduced on a live Mendix 11.8.0 app running in a container (
mxcli run --local --db-type hsqldb) and fixed in its own commit.(1) #818.
journey-runner.js's opt-inui.no5xxrow counted Mendix validation feedback as a server error. A refused save answers HTTP 551 with{"datavalidation":[…]}.helpers.isValidationFeedback. It has the same shape as fix(monkey): score HTTP 551 datavalidation feedback as info, not crash (#803) #814's monkey classifier.record5xxnow awaits the body reads.(2) [bug] fullPageShot crops Atlas pages at the viewport: content scrolls .mx-scrollcontainer-center, not the document #812.
helpers.fullPageShotmeasured the document. On 11.8, Atlas_SideBar and Atlas_TopBar keep the document viewport-tall and scroll.mx-scrollcontainer-center, so the shot was cut at the viewport. Atlas_Default does scroll the document, so the fix has to handle both shapes.fullPage; the record names it inskippedScroller.completeis the root's own leftover scroll height.scrollRoot,contentPx,capturedPx,complete,error.(3) page-audit P1.
DOM_PROBE's[class*="widget-datagrid"]matched a DataGrid2's root plus eight of its parts.live/empty-list-messagethen reported "9 lists on screen; 4 empty" on a 20-row grid. It now matches the.widget-datagridclass token.Impact
no5xx: truestep whose only 5xx was a 551 datavalidation answer. That is the fix. One page-audit verdict can flip FAIL → PASS:live/empty-list-messageon a page whose only "empty lists" were DataGrid2 parts.project-tests/e2e/helpers.js(shared by every e2e instrument),journey-runner.jsandpage-audit.js. New exporthelpers.isValidationFeedback.fullPageShotnow returns a record instead ofundefined; its only caller (full-app-walkthrough.js:183) ignores the return value. Order vs #814: no textual conflict. #814 defines its ownisValidationFeedbackinmonkey.js, so whichever merges second can import the helper (a one-line follow-up). No new tools or artifact reads.skills/, noskill-routing.tsv).fullPageShotcosts extra, and only on an inner-scroll page: one viewport resize, a 250 ms settle, and the restore. On the live app the shot took about 0.4 s against the captured page. A 551 adds one body read. Document-scroll pages and steps without a 551 are unchanged.Time cost: per inner-scroll full-page shot · ~0.3 s measured on a 4-CPU Linux container · can force rework: n · offset: replaces a shot that silently lost everything below 900 px
Fixtures: each new one FAILs on master's file and PASSes on the branch
tests/wave2/test-journey-551-validation.shisValidationFeedback; the captured-551 step FAILs)tests/wave2/test-fullpageshot-inner-scroll.sh734d421d: 6/4, with the shot ballooningtests/wave2/test-page-audit-datagrid-count.shGolden input: all captured, none hand-written (
tests/wave2/fixtures/runtime-mx118/, provenance inCAPTURE.txt):xas-551-empty-required.json: the live runtime's verbatim/xas/answer (status, headers, body) to Save with the required Title empty.overview-SideBar-1280x900.mhtml.gzandoverview-Default-1280x900.mhtml.gz: CDP MHTML snapshots (DOM plus CSS) of the same 20-row DataGrid2 overview under both layouts. Chromium renders them fromfile://with no app./xas/replays the captured answer, next to two controls that must still FAIL: a 500 and a non-datavalidation 551.Existing fixtures that target the changed files. All were run at the branch, scoped:
test-journey-back-no5xx12/0. Its wiring grep now acceptsawait record5xx();. That one-line regex change is in commit 1.test-e2e-visible-wait8/0test-oql-rows15/0test-design-audit-nav-map26/0test-journey-control-exit12/0test-journey-device-net-geo26/26test-journey-id12/0test-journey-liveness36/0test-journey-persona4/0test-journey-preflight75/0test-journey-pseudo-text5/5test-journey-rerun15/15test-journey-row-click7/7test-journey-timeout18/18test-look-ledger35/0test-monkey-left-app22/0test-monkey-oracle14/0test-monkey-template-nav10/0test-named-controls37/0test-navto-missing-itemrc 0test-otel-capture-until4/0test-scope-ensure6/0test-affected-tests160/0test-harness-scan8/8origin/masterworktree, so not caused by this PR:test-stack-up-local: another agent's app held :8080 on the shared box.test-sync-past-stocktest-verify-module-44621/22 (V3: playwright rows=1)Field evidence. A live Mendix 11.8.0 app (blank app plus a Tasks module) scaffolded with
bin/init-project.sh. It was booted withmxcli run --local --watch --db-type hsqldbunder the runtime lock and stopped afterwards. Master's and the branch'sproject-tests/e2e/*.jswere installed into the same app in turn:journey-runner.js journeys/TasksNeg.journey.json(empty-title save,no5xx: true,delta: 0)PASS 5 FAIL 1:FAIL … no HTTP 5xx during the step — 1 answer(s) >= 500: 551 POST http://localhost:8080/xas/PASS 6 FAIL 0:PASS … no answer >= 500 (1 validation answer(s), HTTP 551 datavalidation, not counted: 551 POST http://localhost:8080/xas/)journey-runner.js journeys/Tasks.journey.json(happy path)full-app-walkthrough.jsshot heights (artifacts/app/*.png)H.fullPageShotdirect at 1280×900 / 390×844.mx-scrollcontainer-centerscrollHeight). At 7070fa4, 1280×900: Default 1278, SideBar 1244, TopBar 1239H.fullPageShotwith a 480 px fixed-height grid body injected (the review's case)complete: true. 7070fa4: Default 900, SideBar 900 (the page content),skippedScroller: div.widget-datagrid-grid-body, viewport restoredpage-audit.js --page Tasks.Task_Overview_SideBarlive/empty-list-messageFAIL "9 lists on screen; 4 empty"; verdicts 20 pass / 6 failNot changed, flagged for follow-up (out of this PR's scope):
page-audit.js:590takes its ownpage.screenshot({ fullPage: true })and has the same [bug] fullPageShot crops Atlas pages at the viewport: content scrolls .mx-scrollcontainer-center, not the document #812 crop on inner-scroll layouts.[class*="widget-gallery"]in the sameDOM_PROBEselector is the same substring shape. It probably over-counts Gallery parts and items. It is left unchanged because no Gallery DOM was captured, and rule 1 forbids a hand-written fixture.No client data anywhere in the diff. The fixtures are a demo app on localhost. The leak guard is clean. It warned on two new capitalised words, "Grown" and "TasksNeg"; both are generic.
Size cap: 3 code files, about 100 lines of instrument code; the rest is fixtures, captures and CHANGELOG
Test tier reached: T2–T3. Scoped fixtures ran on captured input, and every instrument ran against a live Mendix 11.8 runtime.
For a new/changed instrument: the golden input is captured. Path resolution is untouched, so both layouts behave as before. The fixtures use
url.pathToFileURLand plain gzip/sed, so they are Git-Bash-safe. They have not been run on macOS or Windows.For a new skill: n/a
CHANGELOG.mdline appended in each commit, credited (bin/check-pr-discipline.shclean)New bug entries: none
Review fix (7070fa4). The independent review's verdict was MERGE-AFTER-FIX: the scroll-root pick ballooned on fixed-height scrollers. Fixed as listed above. The fixture now also re-runs both captures with one appended CSS rule that makes
.widget-datagrid-grid-bodya fixed 480 or 800 px scroller. In the 800 px SideBar case, the outermost root (the centre) must win over the grid body.CAPTURE.txtand the fixture header now give the capture's real row count: 30 rows, 20 per page. Scoped re-runs:Review: pending independent review (re-review of 7070fa4)
https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
Generated by Claude Code