Repository navigation
Conversation
…mode: poc (#819) Build type: poc now reads build-ready as N/A (exit 0, checklist still printed, no open-questions escalation, no build-ready stamp), Stage 5's look check reports MANUAL with the unseen pages named, and `poc` is an Entry mode token that implies Build type: poc. The kick-off brief applies build-ready to full builds only. Fixture tests/wave2/test-fast-lane-poc.sh: 15/15 on the branch, 6/15 on master. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
… is dispatched (#821) Unfilled {{...}} slots in the six agent stubs are a named WARN, not a FAIL; they FAIL again for mdl-agent once its dispatch log exists (.claude/loop/dispatch/<Module>/scripts.tsv). Each stub still refuses to run with a slot left. Fixture tests/wave2/test-fast-lane-agent-slots.sh: 8/8 on the branch, 3/8 on master; test-bug03-gates.sh T18 still names the multi-line slot (99 ok). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
…at FAIL (#821) bin/lib/format-hints.sh holds a minimal passing example for intake markers, the build plan, the coverage ledger, the LOOK report, the prototype LOOK and the improvement-register row. gate-check.sh prints the shapes its FAILs owe after the stage list; obligation FAULTs print theirs after the obligation block; each shape at most once per run. No verdict or exit code changes. Fixture tests/wave2/test-fast-lane-format-hints.sh runs every example through its real parser: 13/13 on the branch, 7/13 on master. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
… lines (#821) One call writes Entry mode / Build type / Interview mode lines, one Stage-P Decisions row each, and an answer marker per intake section in the form check_stage_P parses (flags, --answers verbatim, poc-build.md markers, auto defaults ASSUMED; steering lists the unasked questions), then prints the Stage P verdict. Idempotent; unknown values exit 2 with the accepted list; changing a declared mode exits 3. Fixture tests/wave2/test-kickoff.sh: 26/26 (master has no kickoff.sh). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX (per commit: A MERGE-AFTER-FIX · C HOLD · B MERGE · D MERGE-AFTER-FIX). Top finding: under A,
Generated by Claude Code |
…c; ready names POC pages (review of #828) - Entry mode: poc with a Build type line naming full reads as a full build; gate-check and exec.sh print the conflict, and under auto exec.sh holds it to the requirements-driven plan rule. - "Build type: poc → full (CR-01)" reads as full (gate-check and _position.sh). - The POC Stage 5 MANUAL line keeps the "look: N of M ... never looked at" text bin/ready.sh parses; ready.sh reports that MANUAL as a named FAIL row. Fixture test-fast-lane-poc.sh P5/P6: 21/21. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
… (review of #828) - Rows and markers are CONFIRMED only with --by <person>; without it they are ASSUMED "no person named" (Interview mode: auto included); a later --by run upgrades kickoff's own rows and markers, then is idempotent. - Under steering/assist an unstated --build-type / --interview leaves Q16 / Q9 unanswered and listed first (no register line, no row); auto still assumes full. - Refusal no longer calls an ASSUMED default row "decided". - Kick-off brief line 2: ask first, then record with kickoff.sh --by <name>. Fixture test-kickoff.sh K7/K8: 30/30. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. Re-review of e18f18b. Per commit: A + 9a144ba MERGE-AFTER-FIX · C HOLD (unchanged, maintainer ruling) · B MERGE · D + e18f18b MERGE-AFTER-FIX. Top finding: the fix reads full whenever
It fails in the louder direction, but nothing says why.
The host disk filled up mid-run, so the affected fixtures were rerun once space was back. The stray
Generated by Claude Code |
… warns (re-review of #828) A substring test read `Build type: poc — CONFIRMED (user, fullscreen kiosk)` as a full build, silently: Stages 0-4 owed and exec refused under auto. One shared test, mxtk_bt_names_full (project-bin/_position.sh), now matches full as a word ("full", "poc → full (CR-01)"), never inside one. A poc-prefixed Build type line read as full sets the conflict, and gate-check and exec.sh both print the warning. exec.sh only remaps the plan rule when the Entry mode is poc. Fixture test-fast-lane-poc.sh P5/P7: 25/25. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
…eview of #828) `kickoff.sh --mode poc --by X` left Q9 unanswered, so Stage P FAILed against poc-build.md ("the other intake questions are not asked"). Q9 now takes the POC marker when the build is poc and --interview is not given. Fixture test-kickoff.sh K3 variant: 31/31. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. Third review, of head 616d67d. Per commit: A + 9a144ba + 51d72e7 MERGE · C HOLD (unchanged, waits on the maintainer's ruling) · B MERGE · D + e18f18b + 616d67d MERGE. The one remaining fix is C's ruling. Top finding: both must-fixes from my second review landed and are verified.
Generated by Claude Code |
Direct lane
Fixes #819 (options 1 and 3). Addresses #821 points 1, 2 and 3. Point 4 (
Size tier: smallchanges what is owed) is not in this PR.What changed and why (one paragraph):
Two simulated builds on 2026-11-20 spent 52% (POC) and 75% (requirements-driven) of their cost before the first model write. Neither run had an
exec.shrefusal. The cost came from gate ceremony: agents learned each parsed format one FAIL at a time by reading gate source, filled agent-stub slots for subagents they never dispatched, a POC fabricated an open-questions file to clear a build-ready it should not owe, and kickoff was assembled by hand with Python heredocs. This prototype branch has four commits. Each commit can be cherry-picked on its own: the code applies cleanly alone, and onlyCHANGELOG.mdand two doc lines conflict when the commits are taken out of order.fda21137fix(gate-check, poc) — #819Build type: poc,gate-check.sh <p> build-readystill prints its checklist. It endsBUILD-READY: N/A (Build type: poc)with exit 0, raises no open-questions escalation and writes no.build-ready-passstamp. The exec.sh plan rule already exempted poc and is unchanged. Stage 5's look check reports MANUAL and still names the unseen pages.pocis now anEntry mode:token that implies Build type poc and removes the "No entry mode declared" banner. Artifact and obligation rows stay owed, exactly as forBuild type: poc. Kick-off brief line 3: build-ready applies to full builds only.test-fast-lane-poc.sh15/15 / 6/15 (25/25 after the review fixes)82625470fix(gate-check) — #821 pt 2{{…}}slots in agent stubs become a ⚠ WARN that still names every slot. They FAIL again for mdl-agent once its dispatch log (.claude/loop/dispatch/<Module>/scripts.tsv) exists. Every stub still refuses to run while a slot remains (line 11). This supersedes the 2026-11-13 maintainer decision that any unfilled slot FAILs: the maintainer needs to accept that.test-fast-lane-agent-slots.sh8/8 / 3/81f50ec8anew(gate-check) — #821 pt 1bin/lib/format-hints.shholds one minimal passing example per parsed format: intake markers, build plan, coverage ledger, LOOK report, prototype LOOK, improvement-register row. After the stage list, gate-check prints the shapes that this run's FAILs owe. Obligation FAULTs (look, final-look, prototype-look) print theirs after the obligation block. Each shape prints at most once per run. Informational only.test-fast-lane-format-hints.sh13/13 / 7/13 (the 6 master failures are the missing shapes). Every example is run through its real parser. Two hand-drafted examples failed that check before it was in place: a coverage wildcard hit SECTION-WIDE, and a prototype denominator was too smallb2b9e923new(kickoff) — #821 pt 3bin/kickoff.sh <p> --mode <poc|requirements-driven|migration|change> [--build-type] [--interview] [--answers file] [--by person]writes the register lines, one Stage-P Decisions row each (CONFIRMED only with--by), and one answer marker per intake section, then prints the Stage P verdict. Under steering/assist it lists the unasked questions and never invents answers. It is idempotent. Unknown values exit 2 with the accepted list. Changing an already declared mode exits 3.test-kickoff.sh26/26 / n/a (no kickoff.sh on master; 31/31 after the review fixes)Review fixes (independent review of #828: A and D MERGE-AFTER-FIX, B MERGE, C HOLD). These were added as new commits; no history was rewritten.
9a144ba7(A):Entry mode: pocand aBuild type:line naming full disagree, full wins. gate-check and exec.sh print the conflict, and under auto exec.sh holds the project to the requirements-driven plan rule.Build type: poc → full (CR-01)now reads as full, both in_position.shand in gate-check.look: N of M built page(s) never looked at …text thatbin/ready.shparses. ready.sh now names a POC's unseen pages instead of saying "nothing measured".test-fast-lane-poc.shP5/P6: 21/21.e18f18bc(D):--by <person>. Without it they are ASSUMED, "no person named", and that includesInterview mode: auto. A later--byrun upgrades kickoff's own rows, then is idempotent.--build-type/--interviewleaves Q16 / Q9 unanswered and listed first, with no register line and no row.kickoff.sh … --by <name>.test-kickoff.shK7/K8: 30/30.poc — CONFIRMED (user, fullscreen kiosk)as a full build, silently. One shared test,mxtk_bt_names_full(project-bin/_position.sh), now matchesfullonly as a whole word. Whenever a poc-prefixed Build type line, orEntry mode: poc, is read as full, gate-check and exec.sh both print a ⚠.test-fast-lane-poc.shP5/P7: 25/25. On the reviewer's probe (check5.sh), X1/X2 now print the ⚠, X1 is REFUSED under auto, and X4 ("fullscreen") reaches check with no ⚠.--interview.kickoff.sh --mode poc --by Xwithout--interviewnow gives Q9 poc-build.md's POC marker, so Stage P passes.test-kickoff.shK3 variant: 31/31.bin/kickoff.sh --mode pocwritesEntry mode: poc, a token only A teaches the tokeniser. D's doc lines also sit next to A's, so cherry-picking D without A conflicts. Merge or drop them together.bin/gate-check.sh:2498-2503("review-agent … a project could pass build-ready with the reviewer an inert stub … The count is six") is now stale under C. Build-ready no longer FAILs on an unfilled review-agent stub, so that gap is reopened and left to thelookobligation. If C is accepted, the comment must be rewritten and the ruling recorded inprocess/process-learnings.md. Also: the mdl-agent re-FAIL fires only after mdl-agent has run (agents/README.md step 8a writes the log), and it cannot revoke a sticky.build-ready-pass..leakguard-denycomes fromtest-mode-contract.sh:165,173andtest-ci-gates.sh:163. Both callinit-project.shwithoutMXTK_LEAKGUARD_DENYFILE.Existing fixtures run against the branch (subject = the changed files: gate-check.sh, obligation-check.sh, _position.sh, status.sh, ready.sh, ci-gates.sh): every fixture listed below, all green.
One exception:
test-progress-report-field-fixes.shgave 97/98, then 96/98 with a different failure, then 98/98 on a rerun of the same tree. Master gave 98/98. Itscard … | grep -qassertions look like the pipefail/SIGPIPE flake. That fixture does not touch any changed file. The full suites were not run.Impact
bin/kickoff.sh. Nothing new blocks. One verdict flip for existing projects after sync: a full-build project whose only open build-ready item was stub slots now PASSes build-ready. UnderInterview mode: autothat pass writes the stamp that clears exec.sh's plan rule. Review-agent's stub is no longer forced complete before Stage 5, but thelookobligation still owes the LOOK.bin/gate-check.sh,project-bin/_position.sh(installed beside exec.sh; pure bash and fork-free, so it is still within the exec process budget),bin/lib/artifact-check.sh(one case arm),bin/lib/obligation-check.sh. New:bin/lib/format-hints.sh(sourced by gate-check),bin/kickoff.sh(reads PROJECT.md and intake.md, produced bybin/init-project.sh, the mandatory step 1 of the kick-off brief). New tokeniser outputpoc: every reader was checked. exec.sh / status.sh only test for migration, requirements-driven and greenfield-retired; artifact-check maps poc to "every row owed". No new tools. Order vs other open PRs: not checked.bin/render-routing.sh --checkon master: Baseline 65568 words (budget 80000). On the branch: 65568.skills/poc-build.mdis on-demand (+~45 words).CONVERSION-RUNBOOK.mdis not routed (+~25 words).gate-check.shon a fresh scaffold: 1.81–2.40 s on master vs 2.01–2.70 s on the branch (two rounds of 3–5 runs, this cloud container; noisy, about +0.1–0.3 s from sourcing one more lib and a per-file slot scan). Output grows by the printed shapes only when something FAILs (+10 lines on a fresh scaffold: the intake shape).kickoff.shcosts about 1.5 s, most of it the gate-check P it runs. Time cost: per gate run · +0.1–0.3 s on a Linux cloud container · can force rework: n · offset: removes gate reruns and gate-source reading (sim: 10 and 19 REVERSE calls, 8 and 28 GATE calls before the first exec).Field evidence: two simulated
claude -pbuilds on freshinit-project.shscaffolds, with Mendix tools stubbed: a POC from a brief, and a requirements-driven build from a 232-word spec, 2026-11-20 (SIM-REPORT F1–F4). The fixtures replay the specific failures:Not yet field-run on a real project. The follow-up simulated-build experiment against this branch is the first measurement.
init-project.shscaffolds and the real gate. Not T3.init-project.sh(MXTK_LEAKGUARD_DENYFILEset to a temp file) and judge with the real gate-check / coverage-check. No tool output is parsed by the new code. Both layouts: the changes are register and intake readers plusarchitecture/, and the two-treeapp/layout was not separately exercised. Platforms: bash 3.2-safe constructs, check-portability clean,check-scripts.sh147/147. Not run on macOS or Git Bash.CHANGELOG.mdline per commit, credited.Review: MERGE-AFTER-FIX (re-review of #828 at e18f18b: A/D must-fixes applied in the two commits after it, pending re-review; B MERGE; C HOLD for a maintainer ruling)
https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
Generated by Claude Code