Repository navigation
Conversation
test-mode-contract.sh, test-ci-gates.sh, test-gitignore-crlf.sh and test-must-haves-advisory.sh scaffolded through init-project.sh without MXTK_LEAKGUARD_DENYFILE. run-all.sh sets it, but a scoped run of any of them alone appended its project names (\bhand\b, \bc6\b, \bold\b, ...) to the clone's real .leakguard-deny, and the pre-commit leak guard then flagged nearly every file for the next committer. Each now exports MXTK_LEAKGUARD_DENYFILE into its own scratch dir. New fixture test-fixture-denylist-isolation.sh runs them in a copy of the toolkit with the variable unset and asserts the root denylist is unchanged: 4 FAIL against master, 4 ok on this branch. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX — the four one-line exports are right and complete; the new 250 s fixture re-runs fixtures CI already runs, guards only those four, and a zero-cost run-all.sh sentinel gives the same signal for every fixture. Value: Fixes the issue as reported. Regression risk: None for projects, since only tests/ changed and nothing ships via Correctness: The new fixture works. Narrowed to mode-contract, it gave PASS=1 on the branch (27 s) and caught Context cost: none. Baseline 65568 → 65568 (budget 80000), Time cost: 0 per build row (tests only). CI: +~250 s per PR on a wave2 suite of ~5 min, re-running four fixtures Exact fixes required:
No conflicts with origin/master. Generated by Claude Code |
Review of #829 (MERGE-AFTER-FIX): the 250 s fixture re-ran four fixtures and guarded only those. run-all.sh now empties its exported scratch MXTK_LEAKGUARD_DENYFILE before each fixture and FAILs, by name, any fixture that leaves it non-empty -- i.e. one that relies on run-all's cover and would write the clone's real .leakguard-deny when run alone. Covers every current and future fixture at ~0 s. Proved with a one-fixture symlink-farm harness of run-all.sh: master's test-mode-contract.sh trips it (\bhand\b), the branch's does not. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE — re-review of 47ebe4b: the 250 s fixture is gone, and the run-all.sh sentinel ( Value: Fixes the issue as reported. Regression risk: None for projects: only tests/ changed and nothing ships via
No farm or worktree root denylist was created. Fixtures that export their own path use Correctness: Correct. Non-blocking points:
Context cost: none. Baseline 65568 → 65568 words (budget 80000), from Time cost: 0 per build row. In CI, one No conflicts with origin/master. Generated by Claude Code |
Direct lane
What changed and why (one paragraph): Four wave2 fixtures scaffold throwaway projects through
bin/init-project.shwithout settingMXTK_LEAKGUARD_DENYFILE. These aretest-mode-contract.sh(:165, :173),test-ci-gates.sh(:163),test-gitignore-crlf.sh(:71, :76, :82) andtest-must-haves-advisory.sh(:27, :31, :40).run-all.shexports the variable for every fixture. A scoped run, which is how CLAUDE.md asks fixtures to be run, gets no such cover. In that caseinit-project.sh(~:631) appended the test project names to the clone's real.leakguard-deny:\bhand\b,\bc6\b,\binit-present\b,\binit-missing\b,\binit-fresh\b,\bfresh\b,\bold\band\bmid\b. The pre-commit leak guard then flagged nearly every file for whoever committed next in that clone, and this hit several sessions on 2026-11-19. Each fixture now exportsMXTK_LEAKGUARD_DENYFILE="$WORK/leakguard-deny"right after creating its scratch dir, which the existing trap removes. As a guard against the next fixture that forgets,tests/wave2/run-all.shnow treats the scratchMXTK_LEAKGUARD_DENYFILEit already exports as a sentinel. It empties the file before each fixture and FAILs, by name, any fixture that leaves it non-empty. Such a fixture relies on run-all's cover and would write the clone's real denylist when run alone. A fixture that exports its own path overrides the sentinel and never trips it. The fullgrepoftests/found no other caller: every other fixture that runsinit-project.shalready sets the variable.Option not taken (kept minimal):
init-project.shcould refuse to write the denylist into$TOOLKIT_ROOTwhen the project root is under$TMPDIR. That would also cover fixtures written later, but it changes a shipped script's behaviour, and a real project can live under a temp path. Left for the maintainer to decide.Impact
tests/wave2/run-all.shgains the sentinel; no new toolsrm -fand one[ -s ]per fixture in run-all.shTime cost: per suite run · ~0 s (one rm and one test per fixture) · can force rework: n · offset: replaces the 250 s re-run fixture from the first revision
Proof (run-all.sh has no filter, so the full suite was not run). A harness at
scratchpad/sentinel-harness.shbuilds a symlink farm of the branch worktree. Itstests/wave2/holds only the branch'srun-all.sh,fixtures/and one fixture, and the harness runsrun-all.shthere withMXTK_LEAKGUARD_DENYFILEunset:test-mode-contract.shFAIL test-mode-contract.sh scaffolds via init-project.sh without exporting its own MXTK_LEAKGUARD_DENYFILE (... �hand�),failing 1, rc=1test-mode-contract.shok,failing 0, rc=0.leakguard-deny(the independent review re-ran this too)bash bin/check-scripts.shRevision 2 follows the independent review (MERGE-AFTER-FIX): it removes
test-fixture-denylist-isolation.shand adds the run-all.sh sentinel.Field evidence: observed in this toolkit's own shared clone on 2026-11-19. After scoped fixture runs, the clone's root denylist held
\bhand\band\bc6\b, and the pre-commit leak guard blocked commits from several sessions.CHANGELOG.mdline appended in this PR, crediting the sourceReview: pending independent review
https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
Generated by Claude Code