Repository navigation
Conversation
…enefits API Clients need the monthly reset end, which billingPeriodId does not carry for annual plans. Co-authored-by: Cursor <[email protected]>
… the PR Co-authored-by: Cursor <[email protected]>
Contributor
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owners. @MetaMask/web3auth (6 files)
@MetaMask/core-platform (expand for more) |
tanguyenvn
approved these changes
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The benefits API now returns
benefitPeriodId,benefitPeriodStart, andbenefitPeriodEndfor the monthly allowance window (va-mmcx-subscription-api#218). Annual plans still reset allowances monthly, sobenefitPeriodEndis that reset time rather than the yearly renewal date.subscription-controlleraccepts the three fields as optional (older API responses still validate), stores them onstate.benefits, and keepsbillingPeriodIdas a deprecated alias on the response.References
Checklist
Made with Cursor
Note
Low Risk
Additive, backward-compatible shape changes and state mapping with no auth or payment logic touched.
Reviewed by Cursor Bugbot for commit 0b2a80b. Bugbot is set up for automated code reviews on this repo. Configure here.