Repository navigation
Conversation
Contributor
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owners. @MetaMask/swaps-engineers (16 files)
@MetaMask/core-platform (expand for more) |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5bffc8b. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Populates the
money_account_actionandfailure_phaseMixPanel event propertiesReferences
Checklist
Note
Low Risk
Changes are limited to analytics payloads and failure-phase labeling; no auth, signing, or submission logic changes beyond attaching richer event properties on existing failure paths.
Overview
Adds shared
MoneyAccountAction(withdraw/deposit) andFailurePhasevalueswithdraw_executionanddeposit_executionin bridge-controller, and threads optionalmoney_account_actionthrough Unified SwapBridge event property types and quote helper options.Bridge-status-controller now emits
money_account_actionon Completed/Failed (and related) events when history includes deposit or withdraw tx meta, alignsOperationwith the shared action constants, and classifies failures for MM Pay steps (deposit/withdraw handlers and next-action submit errors) with the new failure phases instead of generic source/destination execution. Failure helpers take history/deposit/withdraw context rather than hashes alone, and tests/snapshots assert the new analytics fields.Reviewed by Cursor Bugbot for commit 63c7608. Bugbot is set up for automated code reviews on this repo. Configure here.