Skip to content

chore: Bump @metamask/analytics-controller from 1.2.1 to 4.3.1 - #4193

Open
cryptodev-2s wants to merge 2 commits into
mainfrom
fix/bump-analytics-controller-4
Open

cryptodev-2s wants to merge 2 commits into
mainfrom
fix/bump-analytics-controller-4

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Replaces #4187, which fails CI.

The bump pulls in reselect@5 (via config-registry-controller), which took the root node_modules/reselect slot and pushed [email protected] (needed by @reduxjs/[email protected]) into a nested folder. That broke the snaps-simulation build with TS2742.

The new version pulls in reselect 5, which pushed reselect 4 (needed by @reduxjs/toolkit) into a nested node_modules and broke the snaps-simulation build with TS2742. Declare reselect 4 in snaps-simulation so it stays hoisted.
@cryptodev-2s
cryptodev-2s requested a review from a team as a code owner November 18, 2026 22:56
@cryptodev-2s cryptodev-2s self-assigned this Nov 18, 2026
@socket-security

socket-security Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​analytics-controller@​1.2.1 ⏵ 4.3.1100 +2100100 +1398 +3100

View full report

@socket-security

socket-security Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@cryptodev-2s

cryptodev-2s commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

All of these come in transitively through @metamask/[email protected] (it now depends on config-registry-controller and keyring-controller). Nothing here is a direct dependency of Snaps. Went through each one:

  • keccak, secp256k1: the usual native crypto addons (prebuilds) used across the MetaMask keyring stack.
  • node-addon-api: only flagged for a clang format helper script in the repo, not shipped code that runs.
  • ethereumjs-wallet, rlp, bs58, ripemd160, ulid: publisher changes and a deprecation notice (renamed to @ethereumjs/wallet). Same packages we already see in the keyring stack, just new in our lockfile.
  • reselect: reads NODE_ENV, which is expected for it. We also pin reselect@^4.1.8 in snaps-simulation to keep the toolkit's copy hoisted.
  • @metamask/eth-sig-util: Socket says the $ { in encodeType breaks EIP 712 hashing. I checked the published 10.0.1 dist and it uses a normal template literal (${propertyType} ${name}), so it's a false positive.

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.69%. Comparing base (52a70c6) to head (7bcaddb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4193   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         429      429           
  Lines       12541    12541           
  Branches     1987     1987           
=======================================
  Hits        12377    12377           
  Misses        164      164           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

},
"dependencies": {
"@metamask/analytics-controller": "^1.2.1",
"@metamask/analytics-controller": "^4.3.1",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, this seems to make the circular dependencies even worse...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we deal with this ?

@cryptodev-2s cryptodev-2s Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move it to be an optional peer dependency or just drop the package and keep a copy of the messenger type

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants