Repository navigation
chore: Bump @metamask/analytics-controller from 1.2.1 to 4.3.1 - #4193
cryptodev-2s wants to merge 2 commits into
Conversation
The new version pulls in reselect 5, which pushed reselect 4 (needed by @reduxjs/toolkit) into a nested node_modules and broke the snaps-simulation build with TS2742. Declare reselect 4 in snaps-simulation so it stays hoisted.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on: |
|
@SocketSecurity ignore npm/[email protected] All of these come in transitively through
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4193 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 429 429
Lines 12541 12541
Branches 1987 1987
=======================================
Hits 12377 12377
Misses 164 164 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| }, | ||
| "dependencies": { | ||
| "@metamask/analytics-controller": "^1.2.1", | ||
| "@metamask/analytics-controller": "^4.3.1", |
There was a problem hiding this comment.
Ouch, this seems to make the circular dependencies even worse...
There was a problem hiding this comment.
How should we deal with this ?
There was a problem hiding this comment.
We could move it to be an optional peer dependency or just drop the package and keep a copy of the messenger type
Replaces #4187, which fails CI.
The bump pulls in
reselect@5(viaconfig-registry-controller), which took the rootnode_modules/reselectslot and pushed[email protected](needed by@reduxjs/[email protected]) into a nested folder. That broke thesnaps-simulationbuild with TS2742.