Repository navigation
Follow links to ids that moved to another page - #192
Merged
Merged
Conversation
When a definition moves to another page, every link to its old URL lands at the top of the old page. mds alone had 114 such moved ids, linked 1,062 times from lds. Vendor qwt's anchor-index.py (Morrison-Lab/qwt#223, #224) and its updated anchor-landing.html, add anchor-index.py to the scaffolding sync, and register it as a post-render step. It writes _site/anchor-index.json (which page holds each id), and anchor-landing.html sends a link to an id missing from its page on to the page that holds it now. mds, sds and macros already run it (mds#878, sds#650, macros#441). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01VDkNzouPjECg79btvrUxmv
Contributor
|
Claude finished review — View run No findings. I checked the PR at
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b4d5fd56422d1e3b6c12c05293e4f2090a50350f",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked anchor-index.py, the anchor-landing.html redirect block, the manifest sha256 values and the post-render config; hashes match and edge cases are guarded.",
"holistic_assessment": "Vendored scaffolding sync from qwt is scoped, adds no dependencies, and the post-render wiring and sync workflow entry are consistent; Quarto render was not run."
}Reviewed commit: b4d5fd5 |
Contributor
Contributor
Built to branch |
Contributor
Author
|
Merging under the standing infra merge grant.
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a definition moves to another page, every link to its old URL lands at the top of the old page. mds alone had 114 such moved ids, linked 1,062 times from lds.
This vendors qwt's
anchor-index.py(Morrison-Lab/qwt#223, #224) and its updatedanchor-landing.html. It also addsanchor-index.pyto the scaffolding sync and registers it as apost-renderstep._site/anchor-index.json, which records the page that holds each id.anchor-landing.htmlsends the reader on to the page that holds it now.mds, sds and macros already run this (mds#878, sds#650, macros#441). This is an infrastructure change, so no content changes.
Generated by Claude Code