[triniwiz]

Adds a way to get an ImageAsset's pixels as the platform's own image type, e.g. to show them in an <Image>:

asset.toNativeImageSync(); // Bitmap | UIImage | WriteableBitmap | GdkTexture | null
asset.toNativeImage();     // the same, decoding off the main thread
asset.toImageSourceSync(); // core ImageSource wrapping it
asset.toImageSource();

It works for assets loaded from encoded data, which are decoded for the call, and for raw-pixel assets.

Platform	Returns	How
Android	Bitmap (ARGB_8888)	nativeWriteToBitmap writes premultiplied RGBA straight into the locked bitmap
iOS	UIImage	new C ABI canvas_native_image_asset_read_pixels_8888, wrapped in a CGImage (sRGB, premultiplied)
Windows	WriteableBitmap	readPixels8888Into writes BGRA straight into its PixelBuffer
Linux	GdkTexture pointer (what core's ImageSource.linux holds)	a GdkMemoryTexture made on the GTK thread; its reference is dropped once the JS pointer is collected

Underneath, canvas-core gains read_pixels_into / read_pixels_8888_into: one Skia conversion into the requested 8-bit layout.

The async forms keep the asset referenced until native code is done with its pointer. The Android callback holds only an id, like the loads since #192.

Testing

• Android: run on an emulator. Bitmaps match the canvas's getImageData exactly for an opaque PNG and within 1 (premultiply rounding) for a PNG with alpha, sync and async. A JPEG shows in a core <Image> through toImageSource().
• iOS: the Swift type-checks against the generated header (swiftc -typecheck, simulator SDK). The xcframework was not rebuilt and nothing was run.
• Windows and Linux: not built locally. This PR's CI is the first compile.

canvas_native.h gets the new declaration by hand in cbindgen's format (both copies); the iOS pre-build and the Android CMake build regenerate it.

Not checked: whether core's Windows ImageSource accepts a WriteableBitmap. It is a valid XAML image source, but core may assume BitmapImage.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 787beae6-52bd-474c-8afc-86a2e88954c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn