Repository navigation
perf(2d): reuse a canvas source's pixels until it changes - #196
Merged
Merged
Conversation
drawImage, createPattern and friends read a canvas back from the GPU, and a threaded one through its render thread, on every call. Both now reuse the last image while nothing was drawn.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
|
ℹ️ Note: npm publishing is disabled for pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drawing a canvas or OffscreenCanvas into another read it back from the GPU (and, when threaded, waited on its render thread) on every call. The last image is now reused until the source is drawn to again.
Stamping ~1000 sprites from an OffscreenCanvas per frame on Linux: 1–2 fps → 60 fps.