Repository navigation
Conversation
|
The documentation retry has finished: build 36000315 fails in the unchanged The earlier build was terminated by Read the Docs' time limit. The same-base documentation retry for #1972 now passes. No documentation, download, or build configuration was changed in this PR. Could someone with access to the Read the Docs project or the GIN dataset check the example-data download from the builder? |
|
@evadiva3 as I said on another of your PRs, we would want a test written for real data (you're welcome to supply a small test dataset) so that we have a way to reproduce the problem. |
A signal chunk ending at the last sample of a Plexon block can replace that block with zeros, including during a default full-signal read. When the right border is zero,
data[:-border]becomesdata[:0]and drops the block.Only trim the right border when it is positive. The regression tests cover full reads, reads within the last block, and chunks ending inside or between blocks. These use synthetic equal-sized blocks; this has not been tested on a real
.plxrecording.Validation:
pytest neo/test/rawiotest/test_plexonrawio.py::TestPlexonAnalogSignalChunk— 2 passed. The end-of-signal test fails on the base code.