Repository navigation
Render validator client config with charon vc-bundle - #523
Draft
KaloyanTanev wants to merge 4 commits into
Draft
KaloyanTanev wants to merge 4 commits into
KaloyanTanev wants to merge 4 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Every validator client
run.shreimplements key import and proposer-settings rendering in shell, and Lighthouse, Nimbus, Prysm and Teku need custom Dockerfiles to get the tools for it. This PR moves that work into charon'scharon alpha vc-bundle, added in ObolNetwork/charon#4844 as part of charon's proposer config stack (https://github.com/ObolNetwork/charon/stack/4832).A one-shot
vc-bundleservice renders the selected VC's keystores and proposer settings into.charon/vc-bundlebefore the VC starts. Eachrun.shcopies its keys and settings into the VC's own data directory and runs only from there, with the distributed-validator flags written inline. The custom Dockerfiles are removed and the upstream images are used. Prysm reads a wallet that charon writes, so no import step is needed.run.shreads them from the bundle'svc-flags.txt, and only the first builder is used.developfor now: its builder flags and builders in the proposer config file are not released yet (latest is 26.10.3).--builder.selection=maxprofit, the only selection under which it applies the boost factor from the proposer settings, soVC_LODESTAR_BUILDER_SELECTIONis removed.docker compose downthenup.docker compose restart <vc>, orup -dwhile the VC is running, keeps the old settings.CHARON_VERSIONto a local build of the stack's top branch.