Repository navigation
rc.4: RetrieveAsync takes a CancellationToken; misnamed parameters renamed - #116
Merged
Merged
Conversation
… parameters renamed (TConn, commandText, procedureName) The three RetrieveAsync overloads that can take a trailing token do; the two params overloads are unchanged. CreateTextCommand(SqlTransaction) in both SQL packages takes commandText, CreateStoredProcedureCommand(IDbConnection) takes procedureName, and the Using/UsingAsync type parameter TConn is TConnection. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…names Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
electricessence
added a commit
that referenced
this pull request
Nov 11, 2026
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two breaking consistency fixes for 11.0.0-rc.4 (API shape).
ExpressiveDbCommand.RetrieveAsynctakes a cancellation tokenRetrieveAsync(),RetrieveAsync(IEnumerable<int> ordinals)andRetrieveAsync(IEnumerable<string> columnNames, bool normalizeColumnOrder = false)gain a trailingCancellationToken cancellationToken = default, passed to the reader open and to the read.paramsoverloads are unchanged: a token cannot followparams, and no token-first overload is added (the house rule is token last). Their docs point to theIEnumerableoverloads for cancellation.Misnamed parameters renamed (source-breaking only for named arguments)
CreateStoredProcedureCommand(IDbConnection, …):commandTextbecomesprocedureName.CreateTextCommand(SqlTransaction, …)in both SQL packages:procedureNamebecomescommandText.Using/UsingAsync: the type parameterTConnbecomesTConnection.PublicAPI.Unshipped.txtcarries a*REMOVED*entry for each changed shipped line.whats-new-11.mdlists both under "Breaking in rc.4".Checks
TokenTerminalTests.Allocation_Channel(shape: Pool): an allocation test on the Channel path, which this PR does not touch, already known to be flaky under load (another build was running at the same time). It was not re-run.Not in this PR: the nullable annotations (item 26), moved to the modernization pass.
🤖 Generated with Claude Code