Repository navigation
Async readers are disposed with ConfigureAwait(false) - #119
Merged
Merged
Conversation
On netstandard2.1 and net10.0 the reader was disposed with a plain 'await using', so its DisposeAsync resumed on the caller's context. Each one now uses the same form as Transaction.cs. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async readers are disposed with
ConfigureAwait(false).On netstandard2.1 and net10.0 the async command paths disposed their
DbDataReaderwith a plainawait using, soDisposeAsyncresumed on the caller's context, against the library rule ofConfigureAwait(false)on every await. Each one now uses the formTransaction.csalready uses:Ten places: nine in
Command._.csand one inExpressiveCommandBase.cs. No otherawait usingin the source lacks it. Behavior is otherwise unchanged; netstandard2.0 still disposes synchronously (itsDbDataReaderhas noDisposeAsync). #117 makes the same change in the command view.Found by the multi-reviewer pass over #111-#118.
Checks
🤖 Generated with Claude Code