You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Array/items: compare items for any schema that has it (not only ArraySchema)
allOf/anyOf/oneOf: flatten allOf/anyOf and compare oneOf members for any schema (not only ComposedSchema); flattening stays as today
Small helpers (SchemaTypes, NumericBounds) in utils keep this in one place. While this phase is in progress they accept both 3.0 and 3.1 shapes. Only existing verdict rules are used.
Done when
All existing tests green, no change in 3.0 verdicts
Paired fixtures for every area pass for 3.1→3.1
No reads of getType(), getNullable(), boolean getExclusiveMinimum/Maximum(), getExample() or instanceof on schema classes left in the engine
Plan: a small SchemaTypes helper in utils that reads the effective type set from both shapes (3.0 typed schemas keep getType(), 3.1 JsonSchema carries the set in getTypes()), and the type/nullable gates in SchemaDiff switched to compare that set instead of the raw getType() string — same approach as #938, generalized so every type read in the engine goes through the helper. "null" in the set goes through the existing nullable rule only, so 3.1 type: [string, "null"] behaves like 3.0 nullable: true. While the phase is in progress the helper accepts both shapes, so 3.0 verdicts stay byte-identical; boolean-sibling handling stays out (that belongs to the numeric-bounds area).
Tests: new paired fixtures under core/src/test/resources/oas31/ (type change and nullable, the two rules in this area) plus a parameterized verdict test for 3.0→3.0 and 3.1→3.1, following the layout of the Phase 0 harness (#961) so the pieces drop together; where the harness already covers these rules, my branch carries the same fixture files so they merge cleanly. Existing suite stays green.
Activity
typechange on referenced component schema is silently ignored #910Inf1mum commentedon Nov 16, 2026
Happy to take Area 1, Types and null.
Plan: a small
SchemaTypeshelper inutilsthat reads the effective type set from both shapes (3.0 typed schemas keepgetType(), 3.1JsonSchemacarries the set ingetTypes()), and the type/nullable gates inSchemaDiffswitched to compare that set instead of the rawgetType()string — same approach as #938, generalized so every type read in the engine goes through the helper."null"in the set goes through the existing nullable rule only, so 3.1type: [string, "null"]behaves like 3.0nullable: true. While the phase is in progress the helper accepts both shapes, so 3.0 verdicts stay byte-identical; boolean-sibling handling stays out (that belongs to the numeric-bounds area).Tests: new paired fixtures under
core/src/test/resources/oas31/(type change and nullable, the two rules in this area) plus a parameterized verdict test for 3.0→3.0 and 3.1→3.1, following the layout of the Phase 0 harness (#961) so the pieces drop together; where the harness already covers these rules, my branch carries the same fixture files so they merge cleanly. Existing suite stays green.