Repository navigation
ci: generate release fixtures in the release job - #9624
Closed
rasswanth-s wants to merge 1 commit into
Closed
rasswanth-s wants to merge 1 commit into
rasswanth-s wants to merge 1 commit into
Conversation
The syft, syft-job and syft-dataset release jobs now write each release's fixture next to its release artifacts and commit both before the build, so every release ships the data later releases test against. The generators skip a fixture that already exists, so a re-run of a failed job passes, and prettier no longer formats any release fixture. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
Author
|
Parking this as a draft. Per the review on #9623, protocol 0 stays open until 1.0.0, so a release must not write release fixtures yet: a fixture freezes v0 the same way an artifact does. #9623 now removes the freeze steps this PR extends, so this branch also conflicts. It can come back, rebased, when we freeze protocol 0 for 1.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every release now writes its release fixtures automatically, so the manual fixture step is gone from the release runbook. A release fixture is a small sample of data exactly as one release wrote it. Later releases' tests load it to prove they still read that data. Stacked on #9623.
Changes
syft,syft-jobandsyft-datasetrelease jobs generate the fixture in the "Freeze release artifacts and fixture" step and commit it with the artifacts. It's inside the release tag and reachesdevwith the release-branch merge.migrations/p2p/fixtures/folder, so the merge-back PR doesn't reformat files that CD wrote.docs/release.mdand the syft-job README describe the automated step; the manual step is removed.Testing
actionlintis clean on the three workflows.Asana task
PR naming convention
Your PR title must follow this format or merging will be blocked:
Example titles:
feat: add retry logic to job approvalfix: handle timeout in notification senderdocs: update syft-bg READMEchore: bump dependenciesrefactor: split init flow into helperstest: add criteria validation testsci: add release train workflowAllowed types:
featfeat: add DS rejection emailsfixfix: handle empty peer listdocsdocs: update syft-bg READMEchorechore: bump dependenciesrefactorrefactor: split init flowtesttest: add approval criteria testscici: add release train workflowperfperf: cache Drive API responsesbuildbuild: pin syft-bg>=0.2.0Just edit the PR title to fix any errors — the check re-runs automatically.
Auto-labeling
Labels are applied automatically — you don't need to add them manually:
feat:addsfeature,fix:addsbugfix)packages/syft-bg/addspkg:syft-bg)These labels are used to auto-generate categorized release notes.
🤖 Generated with Claude Code