Repository navigation
test: give job output viewer fakes log_is_truncated - #9642
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job-testsondev, three tests intest_job_stdout.pypreviously failed. PR feat: say when a log shows only its first characters #9631 made the stdout and stderr viewers calljob_info.log_is_truncated(), but the fake job in these tests, added by PR fix: escape job stdout and stderr before rendering ANSI colors as HTML #9587, did not have that method. The two PRs merged separately, so neither PR's CI caught it. Now the fake job haslog_is_truncated, and returns False.job_stdout.py, after both PRs merged, the file importedhtmland alsofrom html import escape. Now it imports onlyhtml, and the truncation message useshtml.escapelike the rest of the file.Guidelines
High level
Mid level
Low level
Security
No change.
Testing
uv run pytest -n auto packages/syft-job/tests packages/syft-enclave/tests/test_read_permissions.py: 251 passed.Asana task