Repository navigation
fix: show favorited mods first in search results - #1373
Open
vexthatguy wants to merge 1 commit into
Open
vexthatguy wants to merge 1 commit into
vexthatguy wants to merge 1 commit into
Conversation
Tellinq
suggested changes
Nov 20, 2026
| searchedQuery = query | ||
| } | ||
|
|
||
| // Favorite mods first, keeping the provider's ranking within each group (stable sort) |
Contributor
There was a problem hiding this comment.
This comment isn't necessary. I would remove this, and then this PR should be good.
lunaynx
force-pushed
the
v1
branch
4 times, most recently
from
November 20, 2026 18:18
6fea82e to
d7a54ab
Compare
Fixes Polyfrost#1366. Search results previously kept the provider's raw ranking, so favorited mods could appear below non-favorited ones. Re-sort the matching mods with a stable sort that keeps favorites ahead while preserving rank order within each group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1366. Search results previously kept the provider's raw ranking, so favorited mods could appear below non-favorited ones. Re-sort the matching mods with a stable sort that keeps favorites ahead while preserving rank order within each group.
Description
Search results previously kept the provider's raw ranking, so favorited
mods could appear below non-favorited ones. Matching mods are now
re-sorted with a stable sort that keeps favorited mods first while
preserving the provider's rank order within each group.
Related Issue(s)
Fixes #1366