Skip to content

[libc] fix: bounds-check timer id in timer_gettime/settime - #11997

Open
BernardXiong wants to merge 1 commit into
RT-Thread:masterfrom
BernardXiong:fix/posix-timer-id-bounds
Open

BernardXiong wants to merge 1 commit into
RT-Thread:masterfrom
BernardXiong:fix/posix-timer-id-bounds

Conversation

@BernardXiong

Copy link
Copy Markdown
Member

Summary

timer_gettime() and timer_settime() used the caller-supplied timer_t directly as an index into _g_timerid[TIMER_ID_MAX]. timer_delete() already validates the same id range; this brings the sibling paths in line.

Fixes #11980.

Change

Before indexing _g_timerid[], reject ids >= TIMER_ID_MAX with EINVAL in:

  • timer_gettime()
  • timer_settime()

Validation

  • bsp/simulator with RT_USING_POSIX_TIMER=y: the POSIX timer block is active and the modified ctime.c passes a syntax check with no errors. A full simulator link is not possible in this environment because enabling POSIX timers collides with the host signal.h/time.h definitions (pre-existing host-port issue); the change itself introduces no new diagnostics compared with the unmodified file.
  • Runtime RT-Smart QEMU test was not run locally (no cross toolchain).

Note

#11938 touches the same functions for 64-bit truncation but does not validate the id; whichever lands second may need a trivial rebase.

timer_gettime() and timer_settime() indexed _g_timerid[] with the raw
timer_t value, unlike timer_delete(). Reject ids >= TIMER_ID_MAX before
the lookup to keep the table access in bounds.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/posix-timer-id-bounds
    Enter PR branch fix/posix-timer-id-bounds in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/posix-timer-id-bounds 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/posix-timer-id-bounds branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/libc/compilers/common/ctime.c

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/compilers/common/ctime.c

📊 Current Review Status (Last Updated: 2026-11-07 03:05 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] libc: unchecked POSIX timer id in RT-Smart enables EL1 callback execution

1 participant