You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[drivers][touch] Propagate interrupt errors and add framework tests - #12002
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!
为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).
Use workflow from 保持默认分支(通常为 master)
Keep the default branch (usually master) in Use workflow from
在 branch 输入框填写 PR 分支 fix/touch-interrupt-error-propagation
Enter PR branch fix/touch-interrupt-error-propagation in the branch field
设置需排除的文件/目录(目录请以"/"结尾)
Set files/directories to exclude (directories should end with "/")
等待工作流完成 | Wait for the workflow to complete
格式化后的代码将作为独立提交推送至你的分支。
The formatting changes will be pushed to your branch as a separate commit.
完成后,提交将自动更新至 fix/touch-interrupt-error-propagation 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/touch-interrupt-error-propagation branch automatically, and the related Pull Request will be updated.
如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!
Catch memory regressions in CI with MemBrowse. Free for open source.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
为什么提交这份 PR (why to submit this PR)
Touch 设备框架缺少不依赖硬件的专项 utest。框架在
ENABLE_INT、DISABLE_INT和切换到中断模式时会丢弃底层操作的错误码,调用者无法判断中断操作是否成功。本 PR 补齐 RT-Thread issue #11972 中 Touch utest 的缺项,并修复错误码传播。你的解决方案是什么 (what is your solution)
rt_err_t,并从设备控制及设置中断模式的路径返回底层回调结果;使用 pin IRQ 时也返回 pin 中断 API 的结果。请提供验证的 bsp 和 config (provide the config and bsp)
bsp/qemu-vexpress-a9CONFIG_RT_USING_TOUCH=y,CONFIG_RT_USING_UTESTCASES=y,CONFIG_RT_UTEST_TOUCH=y,# CONFIG_RT_TOUCH_PIN_IRQ is not setRT_USING_DEVICE_OPS=y和RT_USING_DEVICE_OPS=n(DFS v1)均完成编译,并在 QEMU 中将utest_run components.drivers.touch.framework 2连续运行两轮,全部通过。RT_TOUCH_PIN_IRQ=y分支完成编译;该配置下模拟回调测试按 Kconfig 依赖关闭。补充格式检查:使用仓库固定的 clang-format 22.1.8,按官方 CI 脚本相同的变更行范围检查 dev_touch.c 和 touch_tc.c,均通过且无需修改。该轮仅检查格式,未重新运行此前已通过的 QEMU 测试。
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up