Skip to content

[bsp][bouffalo] Validate ADC DMA sample channels - #12003

Open
Wooohaaa wants to merge 3 commits into
RT-Thread:masterfrom
Wooohaaa:fix/11949-bouffalo-adc-channel-validation
Open

Wooohaaa wants to merge 3 commits into
RT-Thread:masterfrom
Wooohaaa:fix/11949-bouffalo-adc-channel-validation

Conversation

@Wooohaaa

@Wooohaaa Wooohaaa commented Nov 7, 2026 •

Copy link
Copy Markdown

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

Bouffalo ADC 驱动直接使用调用者传入的通道计算 DMA 缓冲区下标。负数、越界通道以及 BSP 未配置的通道可能读取无效的采样槽。Closes #11949.

你的解决方案是什么 (what is your solution)

  • 在配置 ADC/DMA 和等待读数信号量之前,校验通道的缓冲区范围及 BSP 配置列表。
  • 用命名常量表示原有的 DMA 采样偏移和通道容量。
  • 将校验循环的局部变量放在配置通道的条件分支内,避免没有配置通道时出现未使用变量警告。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: 未在 Bouffalo 硬件上运行,也未进行完整 BSP 编译。
  • .config: 主机测试分别模拟没有配置通道、仅配置 BSP_USING_ADC_CH0 和 BSP_USING_ADC_CH10 两种情况。直接提取 PR 中的通道配置表和校验函数,以 GCC -Wall -Wextra -Werror 编译;每种配置穷举 rt_int8_t 的全部 256 个值,结果均符合配置列表。
  • action: 使用 clang-format 22.1.8,按官方 CI 相同的变更行范围检查,全部通过。上述主机测试不替代 DMA 或硬件验证。

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/11949-bouffalo-adc-channel-validation
    Enter PR branch fix/11949-bouffalo-adc-channel-validation in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/11949-bouffalo-adc-channel-validation 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/11949-bouffalo-adc-channel-validation branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added the BSP label Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] RT-Thread Bouffalo ADC reads outside its DMA sample buffer

1 participant