Repository navigation
chore: Remove dead typechecking code from dev-scripts start command - #10702
Merged
Merged
Conversation
lizschwab
approved these changes
Nov 19, 2026
lizschwab
left a comment
Contributor
There was a problem hiding this comment.
The changes look fine once you resolve the build error. Looks like a lot of changes to the lock file, maybe it did that thing where it removes the optional packages?
Contributor
Author
|
Yep that was it, sorted it out. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR removes dead typechecking code from the dev-scripts
startcommand. This issue was LLM identified and the change was LLM generated; it identified that in RaspberryPiFoundation/blockly-samples#1322, the Webpack loader for Typescript was switched from Babel (which just transpiled without typechecking) to ts-loader (which handles typechecking), but the old code that ran a separate typechecker wasn't removed.I verified that, with this change,
npm run startstill reports type errors in code.