Skip to content

chore: Remove dead typechecking code from dev-scripts start command - #10702

Merged
gonfunko merged 3 commits into
mainfrom
dev-scripts-typecheck
Nov 19, 2026
Merged

gonfunko merged 3 commits into
mainfrom
dev-scripts-typecheck

Conversation

@gonfunko

Copy link
Copy Markdown
Contributor

The basics

The details

Proposed Changes

This PR removes dead typechecking code from the dev-scripts start command. This issue was LLM identified and the change was LLM generated; it identified that in RaspberryPiFoundation/blockly-samples#1322, the Webpack loader for Typescript was switched from Babel (which just transpiled without typechecking) to ts-loader (which handles typechecking), but the old code that ran a separate typechecker wasn't removed.

I verified that, with this change, npm run start still reports type errors in code.

@gonfunko
gonfunko requested a review from lizschwab November 19, 2026 18:25
@gonfunko
gonfunko requested a review from a team as a code owner November 19, 2026 18:25
@github-actions github-actions Bot added the PR: chore General chores (dependencies, typos, etc) label Nov 19, 2026

@lizschwab lizschwab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine once you resolve the build error. Looks like a lot of changes to the lock file, maybe it did that thing where it removes the optional packages?

@gonfunko

gonfunko commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Yep that was it, sorted it out. Thanks!

@gonfunko
gonfunko merged commit c6a8868 into main Nov 19, 2026
6 checks passed
@gonfunko
gonfunko deleted the dev-scripts-typecheck branch November 19, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants