Repository navigation
fix: check first string in common word prefix and suffix - #10706
Open
matthewalberto wants to merge 1 commit into
Open
matthewalberto wants to merge 1 commit into
matthewalberto wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10705
Proposed Changes
Change the two post-loop checks in
commonWordPrefixandcommonWordSuffixto include the first string.Reason for Changes
The result currently depends on option order. This can prevent dropdown labels from being trimmed even when they share a complete word.
Test Coverage
One new dropdown test and two additional checks in the existing prefix and suffix tests. All three fail against the original implementation and pass with the fix. npm test passes (8 of 8 Nx tasks), and Prettier and ESLint are clean.
Documentation
No documentation changes needed.
Additional Information
Claude Code (Claude Opus 5.5) identified and fixed the bug, added three tests, and ran the build. I wrote the issue and PR descriptions and did Playground validation.