Repository navigation
Conversation
- Add null check for user parameter - Make base64 encoding string constant
The function expand_vars was not properly handling the realloc result. The original code did not assign the realloc result to the buf pointer, which could lead to memory leaks. (Possibly out_of_memory() exits, but not sure in context).
- Change variable types from `char *` to `const char *` where appropriate (cppcheck) - Add temporary variable `new_b` for realloc to prevent potential issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C-file fixes from the pre-commit flow branch, one commit per issue: