Repository navigation
Conversation
tarcieri
force-pushed
the
ssh-encoding/max-msg-size
branch
from
November 13, 2026 22:15
e8f03f2 to
f795a18
Compare
Adds a currently private constant (we can consider exposing it, but I kept it private to get started) with a hard maximum on the size of a message to be encoded, mirroring the `SSHBUF_SIZE_MAX` constant from OpenSSH (0x8000000, i.e. 128MiB) To do this `Decoder::new` needs to be fallible, so that's been changed accordingly.
tarcieri
force-pushed
the
ssh-encoding/max-msg-size
branch
from
November 13, 2026 23:45
f795a18 to
2215ddc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a currently private constant (we can consider exposing it, but I kept it private to get started) with a hard maximum on the size of a message to be encoded, mirroring the
SSHBUF_SIZE_MAXconstant from OpenSSH (0x8000000, i.e. 128MiB)To do this
Decoder::newneeds to be fallible, so that's been changed accordingly.