Repository navigation
Conversation
Signed-off-by: zjuncal <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README documents that
sha2_backendtakes precedence oversha2_256_backendandsha2_512_backend. However, setting the global backendto
riscv-zknhand either per-algorithm backend tosoftselects the softwarebackend for that algorithm, because its
softbranch is checked first.Only honor per-algorithm
softoverrides when the global backend is notriscv-zknh. This restores the documented priority for both SHA-256 andSHA-512 while preserving independent per-algorithm selection.
Add a regression check to the existing RISC-V CI job that cross-compiles with
global
riscv-zknhand both per-algorithmsoftoverrides, then checks theemitted assembly for SHA-256 and SHA-512 Zknh instructions. Checking digest
outputs alone would not detect this bug. Also add an entry under
0.11.2 (UNRELEASED)/Fixedin the changelog.This is separate from #935, which corrected the SHA-512 configuration flag
and its intrinsics feature gate.