Repository navigation
fix(react): use server snapshots without storage subscriptions - #10
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useSyncExternalStorecurrently uses the client reconciler implementation, which readsgetSnapshotand schedules subscriptions even during Markdown rendering. Browser-only subscriptions can therefore throwwindow is not definedafter the renderer has already returned its Markdown string, as reported in web-infra-dev/rspress#3858.Intercept this hook with the same behavior as React Fizz: require and read
getServerSnapshot, without callinggetSnapshotor subscribing. Document this requirement and add regressions for distinct client/server snapshots, browser-only subscriptions after the commit callback, and a missing server snapshot.Validation: the regression fails before the fix; all 32 tests pass afterward. ESM/CJS builds, declaration generation, Publint, TypeScript checking, and Biome checks pass.