Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
SoonIter
force-pushed
the
soon-codex/use-official-react-ssr
branch
from
November 12, 2026 08:24
2f9996a to
6883d75
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The direct Markdown renderer currently executes imperative handles, refs, and class mount lifecycles in Node.js, and silently ignores render errors. Keep the existing custom reconciler and Markdown serialization while correcting these SSR behaviors.
Validation: 41 tests pass, including react-dom/server comparisons; builds, TypeScript, Biome, Publint pass. Rspress website builds successfully in an isolated worktree with node_md resolve.alias pointing to the local renderer; 213 Markdown files generated, no React/SSG-MD errors, and both Tabs contents plus surrounding text verified.
Remaining differences: client reconciler ID format is retained; class boundaries may execute their error handlers, but the renderer rejects instead of accepting their fallback. Internal Fiber access is tied to the pinned reconciler and covered by behavior tests.