Exit-code and argument-handling leftovers: -r read errors exit 2, wordlist-gen ignores positionals and flags after them #120

Activity

1. TMHSDigital

   added

   bugSomething isn't workingSomething isn't working

   good first issueGood for newcomersGood for newcomers

   priority: lowNice to haveNice to have

   area: cliFlags, exit codes, main.goFlags, exit codes, main.go

   on Oct 6, 2026
2. TMHSDigital

   added a commit that references this issue on Oct 6, 2026

   fix(cli): lab mode honours env/config resolvers; config precedence fixes

   ...

   9a0df31
3. kragent66-glitch commented on Oct 6, 2026

   

   kragent66-glitch

   on Oct 6, 2026

   Contributor

   More actions

   Hi — I'd like to pick this up.

   I verified each item against HEAD (de87d846) before starting, and the first two are already satisfied there:

   • -r exit code is already 1. A missing -r file now returns exitFailure (main.go:345-349, loadPool) — subenum -r /nonexistent example.com exits 1. Only the parse path (main.go:354-357) still returns exitUsage (2), which is the intended split.
   • Validation already runs before the banner. validateFlags is called before the SIMULATION banner block (main.go:601-616), so subenum -simulate with no domain prints "missing " first, not the banner.

   Still reproducing the wordlist-gen half on HEAD:

   • tools/wordlist-gen.go:156 calls fs.Parse directly, which stops at the first positional. wordlist-gen acme.com -o /tmp/out.txt exits 0, silently ignores both acme.com and the -o after it, and writes ./wordlist.txt (38 common entries).
   • An invalid -combine value and an empty -o both exit 1 instead of 2.

   I'll open a PR that gives wordlist-gen the same interspersed parsing as main.go, rejects leftover positionals with a -domain hint (exit 2), returns exitUsage for the invalid -combine/empty -o cases, and pins each exit code with tests.
4. TMHSDigital

   added a commit that references this issue on Oct 6, 2026

   fix(cli): report a missing domain before reading -exclude-file

   ...

   b39fdc0
5. TMHSDigital commented on Oct 6, 2026

   

   TMHSDigital

   on Oct 6, 2026

   OwnerAuthor

   More actions

   Done on main: unreadable -r exits 1 (9a0df31), usage errors print before the simulation banner, and a missing domain is reported before a missing -exclude-file (b39fdc0). The wordlist-gen positional-argument part is in community PR #133, so this stays open until that lands.
6. TMHSDigital

   added a commit that references this issue on Oct 6, 2026

   fix(wordlist-gen): parse flags interspersed and reject positionals (#133

   ...

   This issue will close once commit 3f74c79 is merged into the 'main' branch.

   3f74c79
7. TMHSDigital

   closed this as completedin #133on Oct 6, 2026