Repository navigation
docs(monitoring): keep ${{ github.token }} in the workflow sample - #216
Merged
TMHSDigital merged 1 commit intoNov 11, 2026
Merged
TMHSDigital merged 1 commit into
TMHSDigital merged 1 commit into
Conversation
Jekyll renders the markdown through Liquid first, so the workflow sample's
three `${{ github.token }}` lines came out as a bare `$`: `GH_TOKEN: $`.
Wrapping that one fenced block in {% raw %} leaves the expressions alone while
the page's {% include %} tags keep rendering.
Closes TMHSDigital#215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled-workflow sample currently renders as
GH_TOKEN: $. Jekyll runs the markdown through Liquid before kramdown sees it, so${{ github.token }}is a Liquid output tag that evaluates to nothing, and all threeGH_TOKEN:lines lose the expression a reader is meant to copy.Wrapping that one fenced block in
{% raw %}/{% endraw %}keeps the expressions literal. Nothing else on the page changes, so the{% include unreleased.html ... %}tags still render. That is also whyrender_with_liquid: falsein the front matter is not the fix here: it would stop every include on the page.How I checked it: rendered
docs/monitoring.mdwith a Liquid engine before and after the change. Before, the three lines came out asGH_TOKEN: $; after, asGH_TOKEN: ${{ github.token }}; the page's three include tags still rendered in both.One correction about what this PR cannot show:
pages.ymlonly builds on a push tomainthat touchesdocs/**(and on a release), so there is no Pages build on a pull request. The first acceptance criterion, the built page showing the expression, can only be seen once this lands. I could not runjekyll buildlocally either: no Ruby on this machine, and the Docker daemon is not running. So the Liquid render above is the local evidence, and the merge is the end-to-end check.Closes #215