Repository navigation
Conversation
qownain
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
November 20, 2026 10:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The iterative binary search reads the midpoint before checking whether the range is empty. For
{2, 3, 4, 10, 40}, searching[2, 1]for4returns2instead of-1. An empty array can also cause an invalid read.This checks the range before reading the array. The added assertions cover empty ranges, boundary values, missing values, and single element ranges.
Validation
C11 compilation with warnings treated as errors, the CMake binary_search target, and all assertions pass. Another 462 range and target combinations match a linear search. Formatting and whitespace checks pass.
The installed clang-tidy cannot load the existing configuration because AnalyzeTemporaryDtors is no longer supported.
Checklist
Prepared with Codex assistance.