Repository navigation
Implement short circuit check for player1 win - #1607
Open
RoryLGroom wants to merge 1 commit into
Open
RoryLGroom wants to merge 1 commit into
RoryLGroom wants to merge 1 commit into
Conversation
Add win check after player places 'x' in Tic Tac Toe. Avoids edge case of player 2 placing after player one has a winning combination, but player 2's choices are selected first.
RoryLGroom
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
November 21, 2026 06:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add checkwin() after player places 'x' in Tic Tac Toe. Avoids edge case of player 2 placing after player one has a winning combination, but player 2's choices are checked first, resulting in player 2 winning.
References
Checklist
Notes:
Short circuit player 1 win in tic tac toe.