Repository navigation
Keep room text and GitHub tokens out of the shell - #147
Open
ThinkOffApp wants to merge 7 commits into
Open
ThinkOffApp wants to merge 7 commits into
ThinkOffApp wants to merge 7 commits into
Conversation
added 7 commits
November 19, 2026 03:43
Run exec as argv via execFileSync. Do not expand ${body}. Reject shell
metacharacters. Live Mac rules are still nudge-only; this closes the
code path Aikido flagged in room-automation.mjs.
Substituted ${room} and ${sender} must match the allowed token and must
not start with -. A failed value refuses the action instead of running
with a missing argument. Commands are split on spaces and run without a
shell; quotes, pipes and redirects in a rule no longer work, by design.
A rule that needs those should call a script file.
send-keys -l takes the text as one argument. Session names use the same strict token as exec substitutions. The pause before Enter is a timer. Tests feed a body with shell characters and check the argv log.
utils.mjs and ide/comment-poller.mjs use the shared tmux helper. Comment pollers and the HTTP adapters GET with fetch; tokens go in headers, not on a command line. Remaining execSync sites are listed in the room.
Inventory only. Values and sources per site. Do not convert these on this branch.
Interval ticks wait for the current poll so a slow fetch cannot reload an independent seen set. send-keys gets -- before the text so a leading dash is not an option. Request-construction errors throw and log a fixed message, never the header value. Worktrees need their own npm install before npm test.
Isolated socket, default server untouched. Capture-pane must show the text that starts with a dash.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room-sourced strings no longer reach a shell in automation, nudges, or pollers. The GitHub token is passed in an Authorization header instead of on a command line. The comment poller delivers each comment once.
This is a large change because the same pattern was copied in many places (33 files, 7 commits on origin/main). A list of remaining
execSyncsites that do not take room text is indocs/remaining-execsync.mdfor a later, separate change.Tests
From this tree:
npm install && npm test(937/937). Independently reproduced withnpm ci --ignore-scripts --no-audit --no-fund && npm test.Live checkouts are not this branch. Merging this PR does not by itself update a running Mac copy.