[EmandM]

Purpose of this PR

Ensure required NetworkManager methods are protected virtual so the base versions can be called when overridden.

Up-port of #4237

Jira ticket

UUM-159597

Changelog

• Fixed: Resolves exceptions being thrown when a derived NetworkManager implements their own Awake.

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

n/a

Backports

Backported by #4237

[u-pr]

💡 Harness Review

The change makes the lifecycle hooks overridable and adds logger fallbacks, but the teardown refactor introduces a syntax error that prevents the package from compiling.

_{Reviewed commit bcb9486}

_{🤖 Helpful? 👍/👎}

[u-pr]

The runtime assembly cannot compile because DestroyInternal now has two opening braces but only one closing brace. The original opening brace remains immediately after the newly added brace. Consequently, subsequent member declarations appear inside DestroyInternal, and the file ends with an unmatched brace. Remove the extra opening brace.

_{🤖 Helpful? 👍/👎}

[NoelStephensUnity]

👍

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	66.66%	9 Missing ⚠️

@@                Coverage Diff                @@
##           develop-3.x.x    #4244      +/-   ##
=================================================
- Coverage          76.75%   76.74%   -0.01%     
=================================================
  Files                159      159              
  Lines              28078    28101      +23     
=================================================
+ Hits               21550    21565      +15     
- Misses              6528     6536       +8     

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	75.79% <66.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	74.73% <66.66%> (-0.22%)	⬇️

Components	Coverage Δ
com.unity.netcode.gameobjects	76.74% <66.66%> (-0.01%)	⬇️

ℹ️ Need help interpreting these results?