Repository navigation
chore(deps): move to Node 24 for CVE-2026-111497 (Brotli RCE) - #121
Merged
Merged
Conversation
…uild works PR #119 bumped tailwindcss from 3.4.19 to 4.3.3 without migrating the config, so `next build` failed with "use @tailwindcss/postcss" and every catalog-analytics deploy since Oct 11 has failed. - Use @tailwindcss/postcss in postcss.config.js (autoprefixer dropped; v4 handles prefixing). - Move the theme from tailwind.config.ts into CSS (@import "tailwindcss", @theme, @Utility), via the official @tailwindcss/upgrade tool. - Rename utilities that changed in v4 (shadow-sm -> shadow-xs, flex-shrink-0 -> shrink-0, bg-gradient-to-* -> bg-linear-to-*, outline-none -> outline-hidden, break-words -> wrap-break-word). - Keep the v3 look: gradients interpolate in sRGB (/srgb), the v3 hex values are pinned for the gray, slate, blue, green, red and yellow palettes, the default border color stays gray-200, and buttons keep the pointer cursor. - Restore `npm run lint`: Next 16 removed `next lint`, so run `eslint .` with a flat config from eslint-config-next.
- uv.lock: certifi 2026.7.22 -> 2026.10.23, filelock 4.1.0 -> 4.2.4, virtualenv 21.14.6 -> 21.14.13 (pip-audit: PYSEC-2026-4320, six filelock CVEs, eight virtualenv CVEs). - next 16.3.8 -> 16.4.3 in catalog and catalog-analytics (GHSA-2464-fhr4-w9xw, GHSA-p3m5-59mp-jv5r, GHSA-673q-mjm6-r5xr). - catalog: nanoid 3.3.17 -> 3.3.20 (Dependabot alert #194), ajv 6.12.6 -> 6.15.0, tar 7.5.20 -> 7.5.22. - catalog-analytics: zod 4.4.3 -> 4.6.7 (GHSA-mrhx-c7xc-m3w5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CVE-2026-111497 ("node2shell") is an out-of-bounds write in the Brotli decoder bundled with Node.js. A crafted br-compressed stream can lead to remote code execution. Node 18 and 20 are end of life and will not get a fix. The fix is in Node 24.22.1 (and 22.23.4 / 26.12.1), from the Node.js security release of Oct 21, 2026.
The live
catalog-analyticsCloud Run service runs on Node 20.20.2. It is still the Oct 5 build, because everyDeploy Catalog Analytics (Cloud Run)run since Oct 11 has failed: #119 bumped tailwindcss from 3.4.19 to 4.3.3 without migrating the config, sonext buildstops with "It looks like you're trying to usetailwindcssdirectly as a PostCSS plugin ... install@tailwindcss/postcss". This PR fixes that too, so merging it gets the live service onto Node 24.What changed
Node 24:
catalog-analytics/Dockerfile:node:20-alpinetonode:24-alpine(resolves to v24.22.1 today)..github/workflows/deploy-catalog-gcp.yml:node-version: '20'to'24'(builds the static catalog site)..github/workflows/code_checks.yml:node-version: '22'to'24'.Tailwind CSS 4 migration in
catalog-analytics(done with the official@tailwindcss/upgradetool, then adjusted so the pages look the same as before):postcss.config.jsuses@tailwindcss/postcss.autoprefixeris removed because Tailwind 4 does its own prefixing.tailwind.config.tsis gone. Its brand colors, font, animations and gradients now live inapp/globals.css(@import "tailwindcss",@theme,@utility). The.card,.card-highlightand gradient helper classes moved to@utility; the CSS variables andbodystyles moved to@layer base.shadow-smtoshadow-xs,flex-shrink-0toshrink-0,bg-gradient-to-*tobg-linear-to-*,focus:outline-nonetofocus:outline-hidden,break-wordstowrap-break-word. These are the same CSS under the new names./srgb(for examplebg-linear-to-r/srgb). v4 blends gradients in OKLab by default, which made the header gradient visibly lighter in the middle.currentcolor), and buttons keep the pointer cursor (v4 preflight dropped it).Security patches (lockfile and version bumps only, no code changes):
uv.lock: certifi 2026.7.22 to 2026.10.23, filelock 4.1.0 to 4.2.4, virtualenv 21.14.6 to 21.14.13. These are what pip-audit incode checksflagged (PYSEC-2026-4320, six filelock CVEs, eight virtualenv CVEs), and why that check was red. Locked with uv 0.9.11, the version CI pins; nothing else in the lock changed.next16.3.8 to 16.4.3 in bothcatalogandcatalog-analytics, for three advisories published Oct 22 (GHSA-2464-fhr4-w9xw and GHSA-673q-mjm6-r5xr are unauthenticated remote code execution, GHSA-p3m5-59mp-jv5r is a denial of service; fixed in 16.4.1).catalog: nanoid 3.3.17 to 3.3.20 (Dependabot alert #194), ajv 6.12.6 to 6.15.0, tar 7.5.20 to 7.5.22.catalog-analytics: zod 4.4.3 to 4.6.7 (GHSA-mrhx-c7xc-m3w5).After this,
npm auditreports 0 vulnerabilities in both apps, pip-audit reports none (with the workflow's existing ignore of GHSA-4xh5-x5gv-qwph), and #194 was the only open Dependabot alert.npm run lintincatalog-analyticsworks again: Next 16 removednext lint, so the script is noweslint .with a neweslint.config.mjsbuilt fromeslint-config-next. It pins the React version foreslint-plugin-react, which cannot detect it under ESLint 10. Lint reports 0 errors and 13 warnings (unused variables and hook dependency hints that were already in the code).How I verified it
All checks below were rerun after the dependency bumps (Next 16.4.3).
catalog-analyticsundernode:24-alpine(v24.22.1):npm ci,npm run lint(0 errors),npx tsc --noEmitandnpm run buildall exit 0. There is no test script.Docker image, built the way
deploy-catalog-analytics.ymlbuilds it (copycatalog/public/dataintocatalog-analytics/public/data, thendocker build catalog-analytics/):node --versionin the image prints v24.22.1.SESSION_SECRETand dummy Google settings:GET /analytics/returns 307 to/analytics/login,GET /analytics/login/returns 200 (/analytics/loginwithout the slash returns 308 to it, same as before).Before and after style comparison. I built the last commit before #119 (a843b35, Node 20, Tailwind 3.4.19, same as what is live) and this branch, ran both with the same data, and compared:
@propertyrules). Every class selector in the old CSS is in the new one after accounting for the renames above, except.table, which v3 generated only because its scanner saw the word "table" in<table>tags; no element uses it as a class./srgband the pinned palette, the same diff showed the header gradient and text colors visibly shifted (up to 28/255), which is why those two adjustments are in.catalog/under Node 24 (node:24-alpine, v24.22.1), with Next 16.4.3:npm ciok,npm run lintexit 0,npm run buildexit 0 (includes the pagefind index step). This is whatdeploy-catalog-gcp.ymlandcode_checks.ymlrun.Python:
uv sync --all-extras --devwith uv 0.9.11, then pip-audit on.venvwith the workflow's ignore list: "No known vulnerabilities found". The repo has no Python unit tests.pre-commit run --all-filesfrom the project venv, as CI runs it: every hook passed.Deploy note
deploy-catalog-gcp.ymlruns on push tomainwhen its own file changes, so merging this redeploys the static catalog site to GCS, built on Node 24.deploy-catalog-analytics.ymltriggers oncatalog-analytics/**, so merging this builds and deployscatalog-analyticson Node 24. Its "Verify deployment" step checks/analytics/login/.catalog-analytics(onlycatalog/), so the build check above is from local runs.