Skip to content

Editor: Add pattern support to PHP-only blocks. - #12522

Open
priethor wants to merge 6 commits into
WordPress:trunkfrom
priethor:priethor/skip-inner-blocks-prompt
Open

priethor wants to merge 6 commits into
WordPress:trunkfrom
priethor:priethor/skip-inner-blocks-prompt

Conversation

@priethor

@priethor priethor commented Jul 14, 2026 •

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/65628

Gutenberg PR: WordPress/gutenberg#80182

What

Extends auto-registered blocks (PHP-only blocks) so they can be edited directly in the canvas through patterns.

Instead of relying on a render_callback, block authors can provide regular block markup as a pattern. The pattern stays synced, and block authors can choose which fields can be overridden for each instance.

Why

PHP-only blocks currently rely on server-rendered previews in the editor and can only be edited through the inspector sidebar.

Testing Instructions

  1. Start the local environment.
  2. Run npm run test:php -- --group 65628.
  3. Confirm all pattern rendering and auto-registration bootstrap tests pass.

The complete editor flow requires the JavaScript changes from Gutenberg PR #80182 and cannot be tested in Core alone until the related package update lands.

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5.6
Used for: Implementation support, test scaffolding, validation. I guided the work and reviewed and adjusted the resulting code and tests.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@priethor
priethor marked this pull request as ready for review July 14, 2026 14:02
@github-actions

github-actions Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

⚠️ PHPStan Static Analysis

PHPStan reported 1 error when analyzing 177bac0 (workflow run). This comment is updated as new commits are pushed.

Errors

These are also shown as annotations on the changed files. They do not fail the check, but they should still be fixed before the pull request is committed. An error that is a false positive may instead warrant being added to a baseline.

Location Error Identifier First reported
src/wp-includes/block-supports/auto-register.php:145 Empty array passed to foreach. foreach.emptyArray 6848d22

Running PHPStan locally

To run the analysis on your own machine, use npm run typecheck:php, or composer phpstan outside the Docker environment.

@priethor
priethor force-pushed the priethor/skip-inner-blocks-prompt branch from 6848d22 to a676d48 Compare November 10, 2026 11:27
…r-blocks-prompt

# Conflicts:
#	src/wp-includes/class-wp-block-type.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant