Skip to content

7.1 Branch: Build/Test Tools: Skip pull_request triggered runs in private repos. - #12984

Closed
desrosj wants to merge 3 commits into
WordPress:7.1from
desrosj:backport/7.1-branch-63183
Closed

desrosj wants to merge 3 commits into
WordPress:7.1from
desrosj:backport/7.1-branch-63183

Conversation

@desrosj

@desrosj desrosj commented Aug 12, 2026 •

Copy link
Copy Markdown
Member

Backports r63183 to the 7.1 branch.

In private forks and mirrors, pull_request workflows no longer run for draft PRs unless the Draft Workflow Runs label is added. The condition is applied to each job on this branch that runs for pull_request events outside of WordPress/wordpress-develop. Workflows from the trunk commit that don't exist on this branch are skipped.

Differences from trunk:

  • uses: references in upgrade-develop-testing.yml and workflow-lint.yml still point to @trunk. This branch has no local reusable workflows.

Trac ticket: https://core.trac.wordpress.org/ticket/65845

Use of AI Tools

This pull request was created by an AI agent (Claude Code). Until this PR is marked "Ready for Review", treat it as untrusted, AI-created code that requires a manual review by a human team member.

🤖 Generated with Claude Code

This modifies the conditions for GitHub Actions workflow runs so that they do not run within private forks and mirrors for `pull_request` events when the PR is in `draft` status.

For situations where this may be desirable, a `Draft Workflow Runs` label can be added to a `draft` pull request to force workflows to run.

Props desrosj, jorbin.
See #65848.

git-svn-id: https://develop.svn.wordpress.org/trunk@63183 602fd350-edb4-49c9-b593-d223f7449a82
@desrosj desrosj self-assigned this Aug 12, 2026
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj
desrosj requested a review from a team November 5, 2026 23:12
@desrosj desrosj changed the title Backport: Skip pull_request triggered runs in private repos - 7.1 Branch 7.1 Branch: Build/Test Tools: Skip pull_request triggered runs in private repos. Nov 5, 2026
@desrosj desrosj moved this from Backlog to In review in WordPress Project Build Tooling Nov 5, 2026
@desrosj
desrosj marked this pull request as ready for review November 6, 2026 00:40
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with r63183 and the 7.1 branch workflows: every pull_request job on this branch now has the same private-repo, draft, and Draft Workflow Runs label condition as trunk (18 jobs across 11 files), and nothing else changes. Workflows trunk touched that this branch lacks are correctly left out. Job uses: lines keep @trunk, which matches how this branch calls its reusable workflows. It merges cleanly into the current 7.1 tip (ada5914). CI: 120 passed, 34 skipped, 0 failed.

AI review · claude-opus-5-5

Resolves a conflict in `.github/workflows/performance.yml`, where the `runs-on` line above the changed `if` condition was updated to `ubuntu-26.04` upstream.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@desrosj

desrosj commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Merged in r65696.

@desrosj desrosj closed this Nov 19, 2026
@desrosj
desrosj deleted the backport/7.1-branch-63183 branch November 19, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants