Skip to content

Code Quality: Fix offsetAccess.nonOffsetAccessible errors by correcting inaccurate type annotations - #13767

Open
arshidkv12 wants to merge 1 commit into
WordPress:trunkfrom
arshidkv12:offsetAccess.nonOffsetAccessible.neon
Open

arshidkv12 wants to merge 1 commit into
WordPress:trunkfrom
arshidkv12:offsetAccess.nonOffsetAccessible.neon

Conversation

@arshidkv12

@arshidkv12 arshidkv12 commented Sep 26, 2026 •

Copy link
Copy Markdown

Fix offsetAccess.nonOffsetAccessible errors by correcting inaccurate type annotations.

  • Correct the $_wp_submenu_nopriv global from bool to array. See 32643, r33957
  • Update WP_Theme::$update to reflect its false or theme update data value. See r35731
  • Remove the offsetAccess.nonOffsetAccessible PHPStan baseline.

See 66739.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arshidkv12, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment thread phpstan.neon.dist Outdated
- tests/phpstan/baselines/method.unused.neon
- tests/phpstan/baselines/notIdentical.alwaysTrue.neon
- tests/phpstan/baselines/nullCoalesce.property.neon
- tests/phpstan/baselines/offsetAccess.nonOffsetAccessible.neon

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Comment by Claude Opus 5.5 (medium effort)

With the commit of r65566, the baseline files are now no longer listed out one-by-one in the phpstan.neon.dist. This change can be reverted and the baselines can be re-generated with the merge from trunk. The conflict on the deleted baseline file comes from the same commit updating its header; keeping the deletion, or re-generating the baselines, resolves it.

@arshidkv12
arshidkv12 force-pushed the offsetAccess.nonOffsetAccessible.neon branch from 561a4d2 to fc995b0 Compare November 21, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants