Skip to content

Query: Don't build relevance order clause when there are no title sea… - #15129

Open
erycson wants to merge 2 commits into
WordPress:trunkfrom
erycson:fix/50871-search-orderby-relevance
Open

erycson wants to merge 2 commits into
WordPress:trunkfrom
erycson:fix/50871-search-orderby-relevance

Conversation

@erycson

@erycson erycson commented Oct 29, 2026 •

Copy link
Copy Markdown

When all search terms are exclusions (e.g. ?s=-foo&orderby=relevance),
search_orderby_title is empty, but missing parentheses in the condition in
WP_Query::get_posts() let orderby=relevance call parse_search_order()
anyway, producing ORDER BY DESC / CASE WHEN THEN 2 and a DB error.
This adds the parentheses so the relevance clause is only built when there
are title terms. Same fix as proposed by leedxw in Trac comment:6.

Trac ticket: https://core.trac.wordpress.org/ticket/50871

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code, with code-intruder (my own static analysis tool)
Model(s): Claude Opus, Claude Haiku
Used for: The issue was surfaced by code-intruder (call-graph regression +
AI review of the flagged sinks). AI helped confirm the root cause, check that
it cannot be escalated to SQL injection, and verify the fix on a clean 7.1.4
install. I reviewed and tested the one-line change myself.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…rch terms.

When all search terms are exclusions (e.g. `?s=-foo&orderby=relevance`),
`search_orderby_title` is empty, but missing parentheses in the condition
made `orderby=relevance` call `parse_search_order()` anyway. This produced
`ORDER BY  DESC` or `CASE WHEN  THEN 2` and a database error.

See #50871.
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props extremsx.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant