Repository navigation
Build/Test Tools: Download and retry the release zip in one job for Installation and Upgrade Tests. - #16106
Build/Test Tools: Download and retry the release zip in one job for Installation and Upgrade Tests.#16106adimoldovan wants to merge 3 commits into
Conversation
…pgrade Tests. For about 20 minutes after a release goes up, some WordPress.org download servers do not have the new zip, so jobs that download it fail. Now one job downloads the zip with WP-CLI, retries for up to 45 minutes, and requires a verified md5 hash. Every job then uses that zip. Runs for latest, nightly and develop do not change. See #66744.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
lancewillett
left a comment
There was a problem hiding this comment.
Thanks, Adi. Downloading the release once makes sense, and the fork runs cover both a published release and a missing one. Please extend the ZIP retention so a maintainer can rerun a failed test job later. The two Zizmor threads are small cleanups that can go in the same edit.
AI review · gpt-6
| path: ${{ runner.temp }}/wordpress-release/wordpress.zip | ||
| if-no-files-found: error | ||
| overwrite: true | ||
| retention-days: 1 |
There was a problem hiding this comment.
Could you set this to retention-days: 30? If a maintainer selects Re-run failed jobs after the first day, GitHub reuses the successful download job’s output. The test job then tries to fetch an expired ZIP and fails before it reaches the test. Keeping the ZIP for 30 days covers the full rerun window. GitHub’s rerun documentation
…the self-repository syntax.
Trac ticket: https://core.trac.wordpress.org/ticket/66744
WordPress.org starts the Installation Tests and Upgrade Tests runs right after it uploads a release. For about 20 minutes, some download servers do not have the new zip yet, and every job that downloads it can fail.
Now one job in each workflow downloads the zip with WP-CLI. It tries every 60 seconds for up to 45 minutes and accepts the zip only when WP-CLI verifies its md5 hash. The test jobs then take the zip from that job instead of downloading it again. WP-CLI does not stop a downgrade when it updates from a zip, so Upgrade Tests skip the update when
wp core update --minoralready reached or passed the target. If the download job fails, the test jobs are skipped and the run reports a failure.Runs for
latest,nightly,trunkanddevelopkeep the current steps. The start versions andwp core update --minorin Upgrade Tests also keep their current download.Testing Instructions
These jobs only run in
WordPress/wordpress-develop. To test on a fork, change thegithub.repositorychecks to the fork's name.5.0.32. One job logsmd5 hash verified, and all test jobs pass.9.9.9. The download job fails after 45 minutes, and the test jobs are skipped.latestandnightly, and Upgrade Tests withlatest. No zip is shared, and the test jobs download WordPress as before.6.4.3. The 6.4 jobs logis not older than 6.4.3, so there is nothing to upgrade.5.9and6.0. The post-install smoke check passes.Test runs on a fork
unzip, so the smoke check passes (#66403).wp core updatedownloads WordPress as before.wp core update --minoralready passed the target.The 9.9.9 runs used a 2-minute wait instead of 45 minutes.
Use of AI Tools
AI assistance: Yes