Skip to content

Build/Test Tools: Download and retry the release zip in one job for Installation and Upgrade Tests. - #16106

Open
adimoldovan wants to merge 3 commits into
WordPress:trunkfrom
adimoldovan:fix/release-zip-download-wait
Open

adimoldovan wants to merge 3 commits into
WordPress:trunkfrom
adimoldovan:fix/release-zip-download-wait

Conversation

@adimoldovan

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/66744

WordPress.org starts the Installation Tests and Upgrade Tests runs right after it uploads a release. For about 20 minutes, some download servers do not have the new zip yet, and every job that downloads it can fail.

Now one job in each workflow downloads the zip with WP-CLI. It tries every 60 seconds for up to 45 minutes and accepts the zip only when WP-CLI verifies its md5 hash. The test jobs then take the zip from that job instead of downloading it again. WP-CLI does not stop a downgrade when it updates from a zip, so Upgrade Tests skip the update when wp core update --minor already reached or passed the target. If the download job fails, the test jobs are skipped and the run reports a failure.

Runs for latest, nightly, trunk and develop keep the current steps. The start versions and wp core update --minor in Upgrade Tests also keep their current download.

Testing Instructions

These jobs only run in WordPress/wordpress-develop. To test on a fork, change the github.repository checks to the fork's name.

  1. Run Installation Tests and Upgrade Tests with a released version, for example 5.0.32. One job logs md5 hash verified, and all test jobs pass.
  2. Run them with a version that does not exist, for example 9.9.9. The download job fails after 45 minutes, and the test jobs are skipped.
  3. Run Installation Tests with latest and nightly, and Upgrade Tests with latest. No zip is shared, and the test jobs download WordPress as before.
  4. Run Upgrade Tests with an older patch, for example 6.4.3. The 6.4 jobs log is not older than 6.4.3, so there is nothing to upgrade.
  5. Run Installation Tests with 5.9 and 6.0. The post-install smoke check passes.

Test runs on a fork

Workflow Version What it proves Run
Installation Tests 5.0.32 One job downloads the zip and verifies its md5 hash. Every test job installs from that zip. see run
Installation Tests 9.9.9 A failed download skips the test jobs and fails the run. see run
Installation Tests latest No zip is shared. The test jobs download WordPress as before. see run
Installation Tests nightly No zip is shared. The test jobs download the nightly build as before. see run
Installation Tests 5.9 Long Twenty Twenty-Two file names survive unzip, so the smoke check passes (#66403). see run
Installation Tests 6.0 The same as 5.9. see run
Upgrade Tests 5.0.32 Every upgrade job updates from the shared zip. see run
Upgrade Tests 9.9.9 A failed download skips all upgrade jobs and fails the run. see run
Upgrade Tests latest No zip is shared. wp core update downloads WordPress as before. see run
Upgrade Tests 6.4.3 The jobs do not downgrade when wp core update --minor already passed the target. see run
Upgrade Develop Version Tests develop Callers that pass no zip, such as release branches, keep the current steps. see run

The 9.9.9 runs used a 2-minute wait instead of 45 minutes.

Use of AI Tools

AI assistance: Yes

…pgrade Tests.

For about 20 minutes after a release goes up, some WordPress.org download servers do not have the new zip, so jobs that download it fail.

Now one job downloads the zip with WP-CLI, retries for up to 45 minutes, and requires a verified md5 hash. Every job then uses that zip. Runs for latest, nightly and develop do not change.

See #66744.
@adimoldovan adimoldovan self-assigned this Nov 19, 2026
@adimoldovan
adimoldovan requested an adaptive review from Copilot November 19, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@adimoldovan
adimoldovan marked this pull request as ready for review November 19, 2026 17:42
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adrianmoldovanwp, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@adimoldovan
adimoldovan requested a review from a team November 19, 2026 17:43

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Adi. Downloading the release once makes sense, and the fork runs cover both a published release and a missing one. Please extend the ZIP retention so a maintainer can rerun a failed test job later. The two Zizmor threads are small cleanups that can go in the same edit.

AI review · gpt-6

path: ${{ runner.temp }}/wordpress-release/wordpress.zip
if-no-files-found: error
overwrite: true
retention-days: 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set this to retention-days: 30? If a maintainer selects Re-run failed jobs after the first day, GitHub reuses the successful download job’s output. The test job then tries to fetch an expired ZIP and fails before it reaches the test. Keeping the ZIP for 30 days covers the full rerun window. GitHub’s rerun documentation

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in f6062af. The zip now stays for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants