Skip to content

External Libraries: Use the classic build of jQuery Form. - #16109

Closed
desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:66711-jquery-form-dist
Closed

desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:66711-jquery-form-dist

Conversation

@desrosj

@desrosj desrosj commented Nov 19, 2026

Copy link
Copy Markdown
Member

As of version 4.4.0, src/jquery.form.js in the jquery-form package is an ES module: it starts with import jQuery from "jquery"; and ends with export default jQuery;. In 4.3.0, the same file was the UMD build.

Because jquery-form is registered as a classic script, browsers reject the file with Cannot use import statement outside a module, and ajaxForm() and ajaxSubmit() are not defined for plugins and themes that enqueue it.

This copies dist/jquery.form.js instead. That is the package's UMD build (its main entry), which matches the format shipped before 4.4.0. The existing minify step and the script registration don't need to change.

Follow-up to r65541.

Testing

Each file was loaded as a classic script after jQuery in headless Chromium:

File ajaxForm / ajaxSubmit Errors
node_modules/jquery-form/src/jquery.form.js (before) undefined Cannot use import statement outside a module
build/wp-includes/js/jquery/jquery.form.js (after) function none
build/wp-includes/js/jquery/jquery.form.min.js (after) function none

The built jquery.form.js is identical to the package's dist/jquery.form.js, and neither built file contains an import or export statement.

Trac ticket: Core-66711

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Verifying the reported cause, making the change, testing the built files in a browser, and drafting this description. Changes were reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 65694
GitHub commit: fa05da8

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants