Skip to content

Editor: Restore the default editor styles for classic themes. - #16118

Open
mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:fix/default-editor-styles
Open

mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:fix/default-editor-styles

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/66762

Use of AI tools

I used Claude Code to find the regression, write the change and test. I reviewed the result.

🤖 Generated with Claude Code

`get_default_block_editor_settings()` read the default editor styles from `wp-includes/css/dist/block-editor/default-editor-styles.css`. The block editor package no longer ships that file, and [65716] deletes it during upgrades. Because of this, the `defaultEditorStyles` setting is always empty in 7.2. Classic themes without their own editor styles, and users who turn off "Use theme styles", lose the default font, font size, line height, block gap, and post title styles.

This moves the CSS from the last shipped version of that file into core, so the setting no longer depends on the file.

Follow-up to [65716].

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 20, 2026
@mukeshpanchal27
mukeshpanchal27 requested a balanced review from Copilot November 20, 2026 05:49
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review November 20, 2026 05:49
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the change restoring fallback block editor styles for classic themes.

No open issues 🎉

What changed in this PR

Restores fallback block editor styles for classic themes by removing reliance on a stylesheet the block editor package no longer ships.

Changes:

  • Defines default typography, block spacing, and post-title styles directly in the editor settings.
  • Adds a regression test confirming the default styles include body font sizing and post-title styling.
File Description
tests/​phpunit/​tests/​blocks/​editor.php Tests the presence and key contents of default editor styles.
src/​wp-includes/​block-editor.php Replaces loading the removed stylesheet with embedded fallback CSS.

Review effort: Balanced

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report.

From the ticket description:

The editor uses defaultEditorStyles in two cases:

  • A classic theme has no editor styles and no theme.json.
  • A user turns off "Use theme styles" in the editor preferences.

In both cases, the editor canvas loses these styles:

  • The system font, 18px font size, 1.5 line height and 2em block gap on body.
  • The 1.8 line height on paragraphs.
  • The size, weight and margins of the post title.

I think this isn't quite accurate, and the impact is narrower.

Since r61473 (7.0), get_block_editor_settings() also passes the global styles CSS to classic themes as a __unstableType: 'theme' entry. Because of this, useEditorStyles in the post editor treats the theme as having theme styles and doesn't use defaultEditorStyles. So for classic themes without editor styles and theme.json, defaultEditorStyles hasn't been used since 7.0, regardless of this file.

The 7.2 regression is limited to two cases:

I tested this with a minimal classic theme. With "Use theme styles" on, both 7.1 and 7.2 show a serif font. With it off, 7.1 shows the system font at 18px, while 7.2 shows a serif font.

Also, the .editor-post-title__block class was removed in WordPress/gutenberg#34489 (WP 5.9), so the post title rule hasn't matched anything since then. There's no need to restore it.

As a quick fix for 7.2, I'd suggest removing the .editor-post-title__block rule from this PR and its test assertion. In the future, we could move these styles to the client side.

Comment on lines +198 to +199
* These styles are used if the "no theme styles" option is triggered or on
* themes without their own editor styles.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* These styles are used if the "no theme styles" option is triggered or on
* themes without their own editor styles.
* These styles are used when the "Use theme styles" preference is turned off
* and in the Customizer widgets editor.

*/
$default_editor_styles = array(
array(
'css' => 'body{font-family:-apple-system,system-ui,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif;font-size:18px;line-height:1.5;--wp--style--block-gap:2em}p{line-height:1.8}.editor-post-title__block{margin-top:2em;margin-bottom:1em;font-size:2.5em;font-weight:800}',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .editor-post-title__block class was removed from the post title in WordPress/gutenberg#34489, so this rule hasn't matched anything since then.

Suggested change
'css' => 'body{font-family:-apple-system,system-ui,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif;font-size:18px;line-height:1.5;--wp--style--block-gap:2em}p{line-height:1.8}.editor-post-title__block{margin-top:2em;margin-bottom:1em;font-size:2.5em;font-weight:800}',
'css' => 'body{font-family:-apple-system,system-ui,"Segoe UI",Roboto,Oxygen-Sans,Ubuntu,Cantarell,"Helvetica Neue",sans-serif;font-size:18px;line-height:1.5;--wp--style--block-gap:2em}p{line-height:1.8}',

Comment on lines +385 to +394
/**
* Tests that the default editor styles are provided without the removed block editor stylesheet.
*/
public function test_get_default_block_editor_settings_default_editor_styles() {
$settings = get_default_block_editor_settings();

$this->assertCount( 1, $settings['defaultEditorStyles'], 'There should be one default editor style.' );
$this->assertStringContainsString( 'font-size:18px', $settings['defaultEditorStyles'][0]['css'], 'The default editor style should set the body font size.' );
$this->assertStringContainsString( '.editor-post-title__block', $settings['defaultEditorStyles'][0]['css'], 'The default editor style should style the post title.' );
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since defaultEditorStyles is a static value, how about adding these assertions to the existing test_get_default_block_editor_settings() instead of a separate test? That test checks each setting one by one, and defaultEditorStyles was the only one missing, which is why this regression wasn't caught. For example:

$this->assertCount( 1, $settings['defaultEditorStyles'] );
$this->assertStringContainsString( 'font-size:18px', $settings['defaultEditorStyles'][0]['css'] );

We could also add @ticket 66762 to its docblock. The .editor-post-title__block assertion can be removed along with the rule.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants