Skip to content

#66766: Sanitize null default_comment_status and default_ping_status to 'closed' - #16123

Open
maniu wants to merge 1 commit into
WordPress:trunkfrom
maniu:66766-sanitize-null-discussion-status
Open

maniu wants to merge 1 commit into
WordPress:trunkfrom
maniu:66766-sanitize-null-discussion-status

Conversation

@maniu

@maniu maniu commented Nov 20, 2026

Copy link
Copy Markdown

Unchecking "Allow people to submit comments on new posts" (or the pingbacks setting) on Settings > Discussion submits null. Since [47808] (5.5), sanitize_option() no longer converts null to 'closed' for default_comment_status and default_ping_status, because '' === $value doesn't match null. With a persistent object cache, get_option() can then return null, and wp_insert_post() fails with "Column 'comment_status' cannot be null".

This casts the value before the empty-string check, matching the (string) cast added for '0' in [56325], which restores the pre-[47808] behaviour for null and false. Unit tests cover both options.

Trac ticket: https://core.trac.wordpress.org/ticket/66766

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Tracing the bug to [47808], drafting the patch, unit test and ticket text; I reviewed, tested and reproduced it on local and production environments.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…ault_ping_status` to `closed`.

Restores the conversion of a null value, which an unchecked checkbox on Settings > Discussion submits, lost in [47808]. This matches the `(string)` cast added for `'0'` in [56325].

See #66766.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +22 to +24
* @dataProvider data_sanitize_option_discussion_status_null
*
* @covers ::sanitize_option

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @dataProvider data_sanitize_option_discussion_status_null
*
* @covers ::sanitize_option
* @covers ::sanitize_option
*
* @dataProvider data_sanitize_option_discussion_status_null

Nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants