Repository navigation
Query: Make get_pages() child_of work with meta queries on interrupted hierarchies. - #16124
shrivastavanolo wants to merge 1 commit into
Conversation
…d hierarchies. See WordPress#14477.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Problem
get_pages()withchild_ofplusmeta_key/meta_valuereturns nothing when a matching descendant's parent does not itself match the meta query. The meta filter is applied in SQL beforeget_page_children()walks the tree, so the parent chain is broken.Change
When
child_ofis set with a meta filter (andincludeis not used), missing ancestors of the matched pages are added temporarily soget_page_children()sees a complete tree. Only the originally matched pages are returned, in hierarchical order. All other calls are unchanged.This deliberately avoids the
$post->ancestorsapproach from [30159], which was reverted in [30735].Trac ticket: https://core.trac.wordpress.org/ticket/14477
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Sonnet 5.5
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.