Repository navigation
Conversation
…tem. See #64548. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64548
The above is closed, but with this PR I'm proposing reopening it. If you prefer I create a different trac ticket, happy to, just let me know.
This patch updates the Notices to look like those that appear inside the site editor, and can be seen in this story. Here are some screenshots:
I've aspired to keep the CSS changes minimal, as it's a visual change, and I've tested a bunch of the major plugins in it, including Woo which looks as it should:
It is worth noting that since this change adds a corner radius—same corner radius used for widgets—some plugins will have rounding:
There's also a use of the Notice inside the customizer, which as a result gets a 0px radius to avoid this:
Why
The motivation is the same as is outlined on the trac ticket: to unify the appearance of the same elements across WordPress. In this case, Notices.
The notice itself uses a full border and toned colour to indicate the type of notice. Not part of this patch, however, the addition of an icon for the type of notice—that's a larger undertaking due to how Notices work in WordPress, but still possibly one to undertake, as colour alone is insufficient to indicate notice type for people of low vision or colour blindness. In that sense, the change is largely stylistic, but the addition of a border all around nevertheless does increase contrast between the notice itself and the background canvas, especially for some colours, e.g. success notices can be hard to see the boundaries of at present:
Thank you for your time.
Use of AI Tools
Claude Opus 5.