Skip to content

Users: Guard against undefined $form in user-profile.js beforeunload handler - #16140

Open
robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:fix/66740-user-profile-beforeunload
Open

robelsust wants to merge 1 commit into
WordPress:trunkfrom
robelsust:fix/66740-user-profile-beforeunload

Conversation

@robelsust

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/66740

Description

src/js/_enqueues/admin/user-profile.js binds its beforeunload handler immediately when the script executes, while $form is only initialized inside the DOM-ready callback. Navigating away from profile.php, user-edit.php, or user-new.php before DOM ready throws:

Uncaught TypeError: Cannot read properties of undefined (reading 'serialize')

Changes

  • Added a $form truthiness check in the beforeunload handler (if ( $form && originalFormContent !== $form.serialize() && ! isSubmitting )) in src/js/_enqueues/admin/user-profile.js.

Testing

  • npx eslint src/js/_enqueues/admin/user-profile.js — passed (0 errors, 0 warnings).
  • Verified beforeunload returns undefined without throwing before DOM ready, returns undefined after DOM ready when the form is unchanged, and returns the unsaved-changes prompt when the form is modified.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props therssoftware.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant