Skip to content

Tests: Register the default script modules in the core entity actions test. - #16146

Open
ekamran wants to merge 1 commit into
WordPress:trunkfrom
ekamran:shifteq/66755-entity-actions-script-modules
Open

ekamran wants to merge 1 commit into
WordPress:trunkfrom
ekamran:shifteq/66755-entity-actions-script-modules

Conversation

@ekamran

@ekamran ekamran commented Nov 21, 2026

Copy link
Copy Markdown

Tests_Entity_Actions_RegisterCoreEntityActions::test_the_script_modules_of_the_core_actions_are_registered() (added in r64566) checks that the @wordpress/core-actions/* modules are registered. Only wp_default_script_modules() registers them, hooked to wp_default_scripts, which fires when a WP_Scripts instance is created. The test does not create one, so it passes only when an earlier test did, and fails when it runs alone or after a class that resets $wp_script_modules in tear_down(), such as Tests_Block_Supports_WpRenderCustomCssClassName.

Trac ticket: https://core.trac.wordpress.org/ticket/66755

What changes

  • The test registers the default script modules itself: it sets $wp_script_modules and $wp_interactivity to null, calls wp_default_script_modules(), and restores both globals in a finally block. wp_default_script_modules() also marks the block library modules for client-side navigation in the Interactivity API, so that global is swapped too.
  • The test no longer goes through the wp_default_scripts action. The loop and its assertions are unchanged, only indented inside the try.

Testing

Locally with PHP 8.4.27, MySQL 9.7.4 and PHPUnit 9.6.39 on single site and multisite:

  • vendor/bin/phpunit --filter test_the_script_modules_of_the_core_actions_are_registered: 1 failure on trunk ("The @wordpress/core-actions/post_type_supports module of post is registered. Failed asserting that null is not null."), OK (1 test, 13 assertions) with this change. Same with -c tests/phpunit/multisite.xml.
  • vendor/bin/phpunit --filter 'Tests_Entity_Actions_RegisterCoreEntityActions::': 16 tests, 1 failure on trunk; OK (16 tests, 65 assertions) with this change, also with --order-by=reverse and with -c tests/phpunit/multisite.xml.
  • Found in full-suite runs with --testsuite default --order-by=random (multisite seeds 101 and 202, single site seed 99).
  • PHPCS reports nothing on the changed file.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, code, local testing and PR wording. I reviewed the reasoning, the code and the test results, and I take responsibility for the contribution.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ekamran.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant