Skip to content

Tests: Reset $wp_styles around the Tests_Embed_Template tests. - #16147

Open
ekamran wants to merge 1 commit into
WordPress:trunkfrom
ekamran:shifteq/66755-embed-template-styles
Open

ekamran wants to merge 1 commit into
WordPress:trunkfrom
ekamran:shifteq/66755-embed-template-styles

Conversation

@ekamran

@ekamran ekamran commented Nov 21, 2026

Copy link
Copy Markdown

The embed output tests in Tests_Embed_Template render the embed template, which enqueues and prints the emoji styles, so wp-emoji-styles is marked as done in $wp_styles. The class resets $wp_scripts in set_up() and tear_down(), but not $wp_styles. When Tests_formatting_wpEnqueueEmojiEtyles::test_wp_enqueue_emoji_styles() runs later, wp_print_styles() skips the handle as already printed and the output is empty.

Trac ticket: https://core.trac.wordpress.org/ticket/66755

What changes

  • set_up() and tear_down() set $wp_styles to null next to $wp_scripts.

Testing

Locally with PHP 8.4.27, MySQL 9.7.4 and PHPUnit 9.6.39, with src/wp-includes/js/wp-embed.js built:

  • With the config below, which runs oembed/template.php and then formatting/wpEnqueueEmojiStyles.php, vendor/bin/phpunit -c pair.xml: 1 failure on trunk ("Failed asserting that '' contains "wp-emoji-styles-inline-css"."), OK (23 tests, 69 assertions) with this change. Same on multisite (the config with <const name="WP_TESTS_MULTISITE" value="1" /> added).
  • vendor/bin/phpunit --filter test_wp_enqueue_emoji_styles: OK (1 test, 4 assertions) before and after.
  • vendor/bin/phpunit --filter 'Tests_Embed_Template::': OK (22 tests, 65 assertions) before and after.
  • Found in a full-suite run with --testsuite default --order-by=reverse, and in a multisite run with --order-by=random --random-order-seed=101.
  • PHPCS reports nothing on the changed file.
<phpunit bootstrap="tests/phpunit/includes/bootstrap.php" backupGlobals="false" convertErrorsToExceptions="true" convertWarningsToExceptions="true" convertNoticesToExceptions="true" convertDeprecationsToExceptions="true">
	<testsuites>
		<testsuite name="pair">
			<file>tests/phpunit/tests/oembed/template.php</file>
			<file>tests/phpunit/tests/formatting/wpEnqueueEmojiStyles.php</file>
		</testsuite>
	</testsuites>
	<php>
		<const name="WP_RUN_CORE_TESTS" value="1" />
	</php>
</phpunit>

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, code, local testing and PR wording. I reviewed the reasoning, the code and the test results, and I take responsibility for the contribution.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ekamran.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant