Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embed output tests in
Tests_Embed_Templaterender the embed template, which enqueues and prints the emoji styles, sowp-emoji-stylesis marked as done in$wp_styles. The class resets$wp_scriptsinset_up()andtear_down(), but not$wp_styles. WhenTests_formatting_wpEnqueueEmojiEtyles::test_wp_enqueue_emoji_styles()runs later,wp_print_styles()skips the handle as already printed and the output is empty.Trac ticket: https://core.trac.wordpress.org/ticket/66755
What changes
set_up()andtear_down()set$wp_stylesto null next to$wp_scripts.Testing
Locally with PHP 8.4.27, MySQL 9.7.4 and PHPUnit 9.6.39, with
src/wp-includes/js/wp-embed.jsbuilt:oembed/template.phpand thenformatting/wpEnqueueEmojiStyles.php,vendor/bin/phpunit -c pair.xml: 1 failure on trunk ("Failed asserting that '' contains "wp-emoji-styles-inline-css"."), OK (23 tests, 69 assertions) with this change. Same on multisite (the config with<const name="WP_TESTS_MULTISITE" value="1" />added).vendor/bin/phpunit --filter test_wp_enqueue_emoji_styles: OK (1 test, 4 assertions) before and after.vendor/bin/phpunit --filter 'Tests_Embed_Template::': OK (22 tests, 65 assertions) before and after.--testsuite default --order-by=reverse, and in a multisite run with--order-by=random --random-order-seed=101.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Investigation, code, local testing and PR wording. I reviewed the reasoning, the code and the test results, and I take responsibility for the contribution.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.