Repository navigation
fix: update codex to 0.170.0 - #780
Merged
Merged
Conversation
benbrandt
pushed a commit
that referenced
this pull request
Nov 19, 2026
🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.0...v2.8.0) (2026-11-19) ### Features * report ACP v2 background work and cancel individual terminals ([#777](#777)) ([74dffa0](74dffa0)) * support MCP-over-ACP in the Codex adapter ([#771](#771)) ([b9503ae](b9503ae)) ### Bug Fixes * align adapter with ACP SDK 2.7 and current protocol rules ([#769](#769)) ([887aab6](887aab6)) * align adapter with ACP SDK 2.8 and current protocol rules ([#775](#775)) ([0a17129](0a17129)) * avoid stack overflow when snapshotting deeply nested JSON ([#742](#742)) ([06425cc](06425cc)) * put model settings first in session config options ([#778](#778)) ([3645fab](3645fab)) * update codex to 0.170.0 ([#780](#780)) ([77b12a1](77b12a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
nyssance
added a commit
to nyssance/codex-acp
that referenced
this pull request
Nov 19, 2026
…ings first Upstream since agentclientprotocol#771: ACP SDK 2.8 alignment (agentclientprotocol#775), v2 background work and terminal cancellation (agentclientprotocol#777), model settings first in config options (agentclientprotocol#778), the deeply nested JSON snapshot fix (agentclientprotocol#742), Codex 0.170.0 (agentclientprotocol#780). Kept from this adapter: - An ordinary v2 prompt during a running turn is still steered into it. A keyed prompt takes upstream's derived message ID and shared receipt and is steered once; a prompt cannot set both an idempotencyKey and _meta.alwith.messageId. - Child interruption still goes through requestTurnInterrupt and its retry. It now reports whether the turn stopped, so a v2 close can require it. - The generated app-server types (--experimental), the image and audio input mapping, the gateway-aware model provider, typed turn failures. Taken from upstream: - A v2 session/cancel stops the foreground and leaves children listed as background work running until they are cancelled themselves or the session closes. The parent-cancellation test follows that rule on v2. - Upstream's field order in shared test fixtures. The deep-nesting snapshot test gets a longer timeout: Bun serializes values about ten times deeper than Node before its stack runs out. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01RaizxxJBbHnYoG9L4g1u5b
mrmans0n
added a commit
to mrmans0n/codex-acp
that referenced
this pull request
Nov 19, 2026
Upstream v2.8.0 (agentclientprotocol#780) updates Codex to 0.170.0, whose regenerated GetAccountResponse requires `userId`; upstream updated every getAccount mock in its tests to `{account: null, userId: null, ...}`. fdcc23c replays cleanly, but its fork point test in session-fork.test.ts still mocks getAccount without `userId`, so `npm run typecheck` fails (TS2741) on the candidate. The adaptation adds `userId: null` to that mock, like upstream's other fork tests. Every other added and removed line is identical to fdcc23c (originally fc9a61e). Upstream's fork changes in v2.8.0 do not touch the fork point contract: agentclientprotocol#775 rejects a fork at an ACP session cursor before the patch checks the neutral _meta fork point, and agentclientprotocol#769 makes forkSessionV2 ignore initial configOptions. resolveForkTurnId and the forkPoint metadata are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
moderationfield. I updated the snapshot and added the required nullablemoderationanduserIdfields to test fixtures.thread/section/changedbecause ACP has no corresponding session update.